Skip to content

Revert source incompatible sharding changes #24126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2017
Merged

Revert source incompatible sharding changes #24126

merged 2 commits into from
Dec 7, 2017

Conversation

johanandren
Copy link
Contributor

@johanandren johanandren commented Dec 7, 2017 •
edited
Loading

We have to revert #24058 since it is source incompatible.

Edit: had the wrong failing sample, now it is the right one

A call like this:

   ClusterSharding(system).start(
      "users",
      entityProps,
      ClusterShardingSettings(system),
      { case EntityMsg(recipientName, payload) => (recipientName, payload) },
      { case EntityMsg(recipientName, _) => recipientName }
    )

Works before the PR is applied but does not compile after it is applied

On top of that there was a bug fix #21809 that also has to be reverted (those fixes should be included in a new PR fixing the source incompatibility)

ping @talpr

@johanandren
Revert "fix entityPropsFactory id param, akka#21809"
c9f41f6 
This reverts commit cd7eae2.
@johanandren
Revert "Merge pull request akka#24058 from talpr/talpr-24053-add-enti…
841e0c8 
…ty-id-to-sharding-props"

This reverts commit 8417e70, reversing
changes made to 22e85f8.
@johanandren johanandren changed the title Revert source incompatible sharding changes johanandren Revert source incompatible sharding changes Dec 7, 2017
@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Dec 7, 2017
@akka-ci
Copy link

akka-ci commented Dec 7, 2017

Test FAILed.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Dec 7, 2017
@akka-ci
Copy link

akka-ci commented Dec 7, 2017

Test FAILed.

@johanandren johanandren mentioned this pull request Dec 7, 2017
Open
@akka-ci akka-ci added validating PR is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Dec 7, 2017
@johanandren
Copy link
Contributor Author

That sbt NPE 🤬

patriknw
patriknw approved these changes Dec 7, 2017
View reviewed changes
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Dec 7, 2017
@akka-ci
Copy link

akka-ci commented Dec 7, 2017

Test FAILed.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Dec 7, 2017
@akka-ci
Copy link

akka-ci commented Dec 7, 2017

Test PASSed.

@johanandren johanandren merged commit 582f6a4 into akka:master Dec 7, 2017
@johanandren johanandren deleted the wip-revert-source-incompatible-sharding-changes-johanandren branch December 7, 2017 16:49
manonthegithub pushed a commit to manonthegithub/akka that referenced this pull request Jan 31, 2018
@johanandren @manonthegithub
Revert source incompatible sharding changes (akka#24126)
07c5add 
* Revert "fix entityPropsFactory id param, akka#21809"
This reverts commit cd7eae2.
* Revert "Merge pull request akka#24058 from talpr/talpr-24053-add-entity-id-to-sharding-props"
This reverts commit 8417e70, reversing
changes made to 22e85f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAILED PersistentClusterShardingWithEntityRecovery
3 participants
@johanandren @akka-ci @patriknw