Only enable line tracing when building with Cython tracing #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only turn it on when we build with line tracing
webknjaz
reviewed
Jun 9, 2025
webknjaz
reviewed
Jun 9, 2025
webknjaz
reviewed
Jun 9, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
webknjaz
approved these changes
Jun 9, 2025
webknjaz
reviewed
Jun 9, 2025
CodSpeed Performance ReportMerging #1521 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
+ Coverage 99.37% 99.62% +0.24%
==========================================
Files 30 29 -1
Lines 6068 5798 -270
Branches 265 265
==========================================
- Hits 6030 5776 -254
+ Misses 35 19 -16
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Only enable line tracing when building with Cython tracing
This PR modifies the build backend to dynamically enable Cython line tracing only when explicitly requested via the
with-cython-tracing=trueconfig setting. Previously, havinglinetrace = "True"in pyproject.toml was causing build issues for users (aio-libs/frozenlist#658) and makes our production wheels almost half as fast.Now, line tracing is opt-in:
pip install .(no line tracing)pip install . --config-setting=with-cython-tracing=true(enables line tracing)When tracing is requested, the build backend automatically adds the
linetrace=Trueandprofile=TrueCython directives and sets the appropriate C compiler flags.Are there changes in behavior for the user?
--config-setting=with-cython-tracing=trueYARL_CYTHON_TRACINGenvironment variable can also be used as an alternative to the config settingRelated issue number
Checklist