Skip to content

DNM: Test PR with line tracing disabled #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

DNM: Test PR with line tracing disabled #1519

wants to merge 3 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 9, 2025

No description provided.

dependabot bot and others added 2 commits June 9, 2025 12:18
@dependabot
Bump cython from 3.0.12 to 3.1.2
a41560b 
Bumps [cython](https://github.com/cython/cython) from 3.0.12 to 3.1.2.
- [Release notes](https://github.com/cython/cython/releases)
- [Changelog](https://github.com/cython/cython/blob/master/CHANGES.rst)
- [Commits](cython/cython@3.0.12...3.1.2)

---
updated-dependencies:
- dependency-name: cython
  dependency-version: 3.1.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@bdraco
DNM: Test PR with line tracing disabled
06d91d3
@bdraco bdraco mentioned this pull request Jun 9, 2025
Merged
3 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 9, 2025

CodSpeed Performance Report

Merging #1519 will improve performances by ×12

Comparing disable_line_tracing (b601569) with master (b1ce302)

Summary

⚡ 36 improvements
✅ 65 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_long_query 5,872.8 µs 482.4 µs ×12
⚡ test_long_query_with_pct 17.9 ms 3.3 ms ×5.5
⚡ test_quote_long_path 4,832.2 µs 404.2 µs ×12
⚡ test_quote_query_string 314.2 µs 71.7 µs ×4.4
⚡ test_quoter_ascii 124.3 µs 52.2 µs ×2.4
⚡ test_quoter_pct 245.7 µs 82.7 µs ×3
⚡ test_quoter_quote_utf8 684.8 µs 143.1 µs ×4.8
⚡ test_unquoter_long_ascii 12.1 ms 4.3 ms ×2.8
⚡ test_unquoter_long_pct 15 ms 6.9 ms ×2.2
⚡ test_unquoter_short 204 µs 115.2 µs +77.12%
⚡ test_extend_query_subclassed_str 1,008 µs 820.9 µs +22.8%
⚡ test_parse_query_uncached[long] 21 ms 14.3 ms +46.72%
⚡ test_parse_query_uncached[short] 1.7 ms 1.3 ms +31.08%
⚡ test_path_safe_uncached 230.9 µs 152.3 µs +51.64%
⚡ test_update_query_mapping 946.1 µs 781.8 µs +21.01%
⚡ test_update_query_mapping_with_existing_query 1,260.4 µs 991.2 µs +27.16%
⚡ test_update_query_sequence_mapping 4.5 ms 3 ms +52.89%
⚡ test_update_query_string 612.3 µs 533.7 µs +14.72%
⚡ test_url_build_access_raw_path 597.1 µs 529.3 µs +12.81%
⚡ test_url_build_no_netloc 431 µs 331.7 µs +29.95%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@webknjaz
Copy link
Member

webknjaz commented Jun 9, 2025

@bdraco are you going to download the wheels from GHA and test them locally?

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (b1ce302) to head (b601569).
Report is 3 commits behind head on master.

❌ Your project status has failed because the head coverage (98.05%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
+ Coverage   99.37%   99.62%   +0.24%     
==========================================
  Files          30       29       -1     
  Lines        6068     5790     -278     
  Branches      265      265              
==========================================
- Hits         6030     5768     -262     
+ Misses         35       19      -16     
  Partials        3        3
Flag Coverage Δ
CI-GHA 99.62% <ø> (+0.24%) ⬆️
MyPy 98.05% <ø> (ø)
OS-Linux 99.75% <ø> (+0.30%) ⬆️
OS-Windows 99.48% <ø> (ø)
OS-macOS 99.48% <ø> (+0.15%) ⬆️
Py-3.10.11 99.45% <ø> (+0.33%) ⬆️
Py-3.10.17 99.70% <ø> (+0.34%) ⬆️
Py-3.11.12 99.70% <ø> (+0.34%) ⬆️
Py-3.11.9 99.45% <ø> (+0.33%) ⬆️
Py-3.12.10 99.70% <ø> (+0.34%) ⬆️
Py-3.13.3 99.70% <ø> (+0.34%) ⬆️
Py-3.13.3t ?
Py-3.13.4t 99.70% <ø> (-0.05%) ⬇️
Py-3.9.13 99.41% <ø> (+0.33%) ⬆️
Py-3.9.22 99.65% <ø> (+0.34%) ⬆️
Py-pypy7.3.16 99.33% <ø> (ø)
Py-pypy7.3.19 99.36% <ø> (ø)
VM-macos-latest 99.48% <ø> (+0.15%) ⬆️
VM-ubuntu-latest 99.75% <ø> (+0.30%) ⬆️
VM-windows-latest 99.48% <ø> (ø)
pytest 99.75% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco
Copy link
Member Author

bdraco commented Jun 9, 2025

@bdraco are you going to download the wheels from GHA and test them locally?

yes

@bdraco
Copy link
Member Author

bdraco commented Jun 9, 2025

There is still something going wrong here.

When I install yarl 1.20.0 from PyPI I get 0.036 on quoting ascii benchmark.

When install the wheels with tracing disabled here I get 0.073....

@bdraco
Copy link
Member Author

bdraco commented Jun 9, 2025

Now I downloaded the latest build and its 0.020 sec ....

@bdraco
Copy link
Member Author

bdraco commented Jun 9, 2025 

bdraco@MacBook-Pro-37 PKGS % pip3 install --upgrade yarl-1.20.1.dev0-cp313-cp313-macosx_11_0_arm64.whl
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
Processing ./yarl-1.20.1.dev0-cp313-cp313-macosx_11_0_arm64.whl
Requirement already satisfied: idna>=2.0 in /opt/homebrew/lib/python3.13/site-packages (from yarl==1.20.1.dev0) (3.10)
Requirement already satisfied: multidict>=4.0 in /opt/homebrew/lib/python3.13/site-packages (from yarl==1.20.1.dev0) (6.4.4)
Requirement already satisfied: propcache>=0.2.1 in /opt/homebrew/lib/python3.13/site-packages (from yarl==1.20.1.dev0) (0.3.1)
yarl is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
bdraco@MacBook-Pro-37 PKGS % python3 benchmark.py 
Cython quote ascii: 0.020 sec
Python quote ascii: 0.955 sec
Cython quote PCT: 0.049 sec
Python quote PCT: 1.128 sec
Cython quote: 0.139 sec
Python quote: 4.328 sec
Cython unquote: 0.071 sec
Python unquote: 0.841 sec
bdraco@MacBook-Pro-37 PKGS % pip3 uninstall yarl
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
Found existing installation: yarl 1.20.1.dev0
Uninstalling yarl-1.20.1.dev0:
  Would remove:
    /opt/homebrew/lib/python3.13/site-packages/yarl-1.20.1.dev0.dist-info/*
    /opt/homebrew/lib/python3.13/site-packages/yarl/*
Proceed (Y/n)? y
  Successfully uninstalled yarl-1.20.1.dev0
bdraco@MacBook-Pro-37 PKGS % pip3 install yarl
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
Collecting yarl
  Using cached yarl-1.20.0-cp313-cp313-macosx_11_0_arm64.whl.metadata (72 kB)
Requirement already satisfied: idna>=2.0 in /opt/homebrew/lib/python3.13/site-packages (from yarl) (3.10)
Requirement already satisfied: multidict>=4.0 in /opt/homebrew/lib/python3.13/site-packages (from yarl) (6.4.4)
Requirement already satisfied: propcache>=0.2.1 in /opt/homebrew/lib/python3.13/site-packages (from yarl) (0.3.1)
Using cached yarl-1.20.0-cp313-cp313-macosx_11_0_arm64.whl (94 kB)
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
Installing collected packages: yarl
WARNING: Ignoring invalid distribution ~sphome (/opt/homebrew/lib/python3.13/site-packages)
Successfully installed yarl-1.20.0
bdraco@MacBook-Pro-37 PKGS % python3 benchmark.py
Cython quote ascii: 0.042 sec
Python quote ascii: 0.958 sec
Cython quote PCT: 0.125 sec
Python quote PCT: 1.107 sec
Cython quote: 0.415 sec
Python quote: 5.799 sec
Cython unquote: 0.075 sec
Python unquote: 0.834 sec
bdraco@MacBook-Pro-37 PKGS %

So this implies we have been shipping wheels with line tracing on

@bdraco bdraco closed this Jun 9, 2025
@bdraco bdraco deleted the disable_line_tracing branch June 9, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @webknjaz