Skip to content

Conversation

lysnikolaou
Copy link
Contributor

What do these changes do?

Since we're setting (and not extending) norecursedirs, .hypothesis should also be there, otherwise we might be getting spurious warnings like the ones in this test run.

Are there changes in behavior for the user?

No.

Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #1480 will not alter performance

Comparing lysnikolaou:add-hypothesis-norecursedirs (b0d225e) with master (3209565)

Summary

✅ 99 untouched benchmarks

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do ansible/awx-plugins@e9bcd0c instead?

@lysnikolaou
Copy link
Contributor Author

Done!

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this deserves a contrib change note..

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 11, 2025
@lysnikolaou lysnikolaou changed the title Add hypothesis folder to pytest's norecursedirs Add hidden folders to pytest's norecursedirs Mar 11, 2025
@lysnikolaou
Copy link
Contributor Author

Added a contrib change note. Thanks for the suggestion @webknjaz!

@lysnikolaou lysnikolaou force-pushed the add-hypothesis-norecursedirs branch from efb1bfd to b0d225e Compare March 12, 2025 11:14
@bdraco
Copy link
Member

bdraco commented Mar 13, 2025

Thanks @lysnikolaou

@bdraco bdraco merged commit a96ac9c into aio-libs:master Mar 13, 2025
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants