Skip to content

Increase minimum propcache version to 0.2.1 #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 3, 2025

What do these changes do?

Ensure propcache 0.2.1 or later is used so the tests will pass

Are there changes in behavior for the user?

propcache 0.2.1 is now required

Related issue number

fixes #1457

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 3, 2025
@bdraco bdraco marked this pull request as ready for review March 3, 2025 20:20
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #1479 will not alter performance

Comparing bump_min_prop_cache (bb4019b) with master (0db43c6)

Summary

✅ 99 untouched benchmarks

@bdraco
Copy link
Member Author

bdraco commented Mar 4, 2025

wip/app#792

@bdraco bdraco closed this Mar 5, 2025
@bdraco bdraco reopened this Mar 5, 2025
@bdraco bdraco changed the title Increase minimum propcache version to 0.2.1 Increase minimum propcache version to 0.2.1 Mar 5, 2025
@bdraco bdraco changed the title Increase minimum propcache version to 0.2.1 Increase minimum propcache version to 0.2.1 Mar 5, 2025
@bdraco bdraco enabled auto-merge (squash) March 5, 2025 00:19
@bdraco bdraco merged commit 3209565 into master Mar 5, 2025
86 of 88 checks passed
@bdraco bdraco deleted the bump_min_prop_cache branch March 5, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail with object has no attribute 'wrapped' in propcache
1 participant