Skip to content

DNM: test hit rate of a join cache #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

DNM: test hit rate of a join cache #1433

wants to merge 3 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 29, 2024

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1433 will improve performances by ×2

Comparing join_cache (1ccad7e) with master (22544b1)

Summary

⚡ 2 improvements
✅ 83 untouched benchmarks

Benchmarks breakdown

Benchmark master join_cache Change
⚡ test_url_hash 193.4 µs 96.6 µs ×2
⚡ test_url_join 251.9 µs 185.1 µs +36.05%

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (22544b1) to head (1ccad7e).
Report is 35 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage   96.11%   96.12%   +0.01%     
==========================================
  Files          31       31              
  Lines        5871     5890      +19     
  Branches      348      348              
==========================================
+ Hits         5643     5662      +19     
  Misses        202      202              
  Partials       26       26
Flag Coverage Δ
CI-GHA 96.12% <100.00%> (+0.01%) ⬆️
MyPy 49.56% <95.45%> (+0.20%) ⬆️
OS-Linux 99.55% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.62% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.30% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.28% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 99.24% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.47% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.53% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.55% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.30% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.55% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.62% <100.00%> (+<0.01%) ⬆️
pytest 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Nov 29, 2024

Its actually a lot better than I was expecting

2024-11-29 11:00:02.628 CRITICAL (SyncWorker_5) [homeassistant.components.profiler] Cache stats for lru_cache <function URL._join at 0x7ffa4ae40860> at /usr/local/lib/python3.13/site-packages/yarl/_url.py: CacheInfo(hits=699, misses=67, maxsize=128, currsize=67)

@bdraco bdraco mentioned this pull request Nov 29, 2024
Merged
@bdraco
Copy link
Member Author

bdraco commented Nov 29, 2024

closing in favor of #1434

@bdraco bdraco closed this Nov 29, 2024
@bdraco bdraco deleted the join_cache branch November 29, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco