Fix regression: #258
Merged
Fix regression: #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
asvetlov
commented
Nov 10, 2021
- Don't raise TimeoutError from timeout object that doesn't enter into async context manager
- Use call_soon() for raising TimeoutError if deadline is reached on entering into async context manager
1. Don't raise TimeoutError from timeout object that doesn't enter into async context manager 2. Use call_soon() for raising TimeoutError if deadline is reached on entering into async context manager
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 109 116 +7
Branches 16 18 +2
=========================================
+ Hits 109 116 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@achimnol does the PR fix your problem? |
YES!!! My test cases came back normal as with both async-timeout v3 series and this PR. 🙏🏼 |
|
Cool! |
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Nov 11, 2021
* aio-libs/async-timeout#258 fixes early-expring timeouts used within async generators, which was a regression in async-timeout 4.0.0.
achimnol
added a commit
to lablup/backend.ai-common
that referenced
this pull request
Nov 11, 2021
* fix: Update async-timeout API usage * test: Update async-timeout API usage * test: Fix docker-compose container naming to be compatible with docker-compose 2.0 and 2.1 * fix: Catch TimeoutError in addition to asyncio.TimeoutError - aioredis v2 often wraps asyncio.TimeoutError with TimeoutError * test: Distinguish PING/PONG msgs for readiness checks * setup: Upgrade async-timeout to a compatible version (4.0.1) - aio-libs/async-timeout#258 fixes early-expring timeouts used within async generators, which was a regression in async-timeout 4.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.