This repository was archived by the owner on Jul 16, 2024. It is now read-only.
fix: Update async_timeout usage #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aioredis v2 often wraps asyncio.TimeoutError with TimeoutError
* aio-libs/async-timeout#258 fixes early-expring timeouts used within async generators, which was a regression in async-timeout 4.0.0.
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 75.09% 75.84% +0.75%
==========================================
Files 23 23
Lines 3192 3192
==========================================
+ Hits 2397 2421 +24
+ Misses 795 771 -24
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async withinstead ofwith.so upgrade to 4.0.1 which fixed the problem by Fix regression: aio-libs/async-timeout#258.
asyncio.TimeoutErrorwithTimeoutErrorin some cases,so catch them as well.