Skip to content

Remove deprecation warning #3481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Remove deprecation warning #3481

merged 1 commit into from
Jan 4, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 3, 2019

Fixes #3480

@codecov-io
Copy link

codecov-io commented Jan 3, 2019 •
edited
Loading

Codecov Report

Merging #3481 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3481      +/-   ##
==========================================
+ Coverage   97.94%   97.94%   +<.01%     
==========================================
  Files          44       44              
  Lines        8564     8678     +114     
  Branches     1383     1410      +27     
==========================================
+ Hits         8388     8500     +112     
- Misses         73       74       +1     
- Partials      103      104       +1
Impacted Files Coverage Δ
aiohttp/web_response.py 98.41% <100%> (ø) ⬆️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️
aiohttp/payload.py 99.09% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37722f8...93dc501. Read the comment docs.

@asvetlov asvetlov merged commit 0715ae7 into master Jan 4, 2019
@asvetlov asvetlov deleted the correct-abc-module branch January 4, 2019 16:04
asvetlov added a commit that referenced this pull request Jan 4, 2019
@asvetlov
Fix #3480: Remove deprecation warning (#3481)
42cea2d
@lock
Copy link

lock bot commented Jan 4, 2020

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Jan 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR bug outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning in web_response.py with Python 3.7
3 participants
@asvetlov @codecov-io @aio-libs-bot