Reviewing files that changed from the base of the PR and between 1b1e089 and 57ae256.

• Cargo.lock is excluded by !**/*.lock
• lib/bindings/python/Cargo.lock is excluded by !**/*.lock

• Earthfile (1 hunks)
• container/Dockerfile.none (1 hunks)
• container/Dockerfile.tensorrt_llm (1 hunks)
• container/Dockerfile.vllm (1 hunks)
• launch/dynamo-run/Cargo.toml (0 hunks)
• launch/dynamo-run/src/lib.rs (0 hunks)
• launch/dynamo-run/src/main.rs (1 hunks)
• launch/dynamo-run/src/opt.rs (0 hunks)
• lib/bindings/python/Cargo.toml (1 hunks)
• lib/bindings/python/rust/engine.rs (2 hunks)
• lib/engines/python/Cargo.toml (0 hunks)
• lib/engines/python/src/lib.rs (0 hunks)

• launch/dynamo-run/src/lib.rs
• lib/engines/python/Cargo.toml
• launch/dynamo-run/src/opt.rs
• launch/dynamo-run/Cargo.toml
• lib/engines/python/src/lib.rs

• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: Build and Test - vllm
• GitHub Check: pre-merge-rust (.)

launch/dynamo-run/src/main.rs (2)

29-29: LGTM: Example model updated.

The model name change in the example usage is appropriate and keeps the documentation current.

---

33-33: LGTM: Usage string updated to reflect Python engine removal.

The removal of "dyn://<path>" syntax from the usage string is consistent with removing the bring-your-own-engine Python support.

lib/bindings/python/Cargo.toml (1)

44-47: LGTM: Dependencies updated for new Rust-based Python engine.

The addition of anyhow, async-stream, async-trait, and async-openai dependencies aligns with implementing a new Rust-native async engine to replace the external Python engine support.

Earthfile (1)

115-115: LGTM: Python feature removed from build configuration.

The removal of the python feature from the cargo build command is consistent with eliminating bring-your-own-engine Python support while maintaining other necessary features.

container/Dockerfile.tensorrt_llm (1)

278-283:

✅ Verification successful

Verify that mistralrs feature removal doesn't break TensorRT-LLM functionality.

The cargo build command now runs without any features, which removes both python and mistralrs features. While removing python aligns with the PR objectives, please confirm that the mistralrs feature is not required for TensorRT-LLM builds.

---

🏁 Script executed:

#!/bin/bash
# Description: Check if mistralrs feature is required for TensorRT-LLM builds
# Expected: Find references to mistralrs in TensorRT-LLM related code or configs

# Search for mistralrs references in TensorRT-LLM context
rg -i "mistralrs|mistral.*rs" --type dockerfile
rg -i "mistralrs|mistral.*rs" container/
rg -i "tensorrt.*mistral|mistral.*tensorrt" 

# Check if mistralrs is conditionally compiled for tensorrt
ast-grep --pattern 'cfg(feature = "mistralrs")'

Length of output: 757

---

🏁 Script executed:

#!/bin/bash
# Inspect Cargo.toml for mistralrs feature definitions and default features

# 1. Find all occurrences of 'mistralrs' in TOML files
rg -n "mistralrs" --glob "*.toml"

# 2. Locate and display [features] sections in crates 'dynamo-run' and 'llmctl'
rg -l 'name = "dynamo-run"' -R "*.toml" | xargs -I{} sh -c 'echo "== {} =="; sed -n "/^\[features\]/,/^\[/{p}" {}'
rg -l 'name = "llmctl"'   -R "*.toml" | xargs -I{} sh -c 'echo "== {} =="; sed -n "/^\[features\]/,/^\[/{p}" {}'

# 3. Check for any use of default-features toggles
rg -n "default-features" --glob "*.toml"

Length of output: 2931

---

Mistralrs remains enabled via default features

The cargo build in container/Dockerfile.tensorrt_llm no longer passes an explicit --features flag, but it still picks up the crate’s default features. In launch/dynamo-run/Cargo.toml, the default features list is set to ["mistralrs"], so the mistralrs engine is still compiled in without any additional flags. No further changes are needed here.

container/Dockerfile.none (1)

49-55:

❌ Incorrect review comment

Consider passing feature flags or --workspace to avoid an accidental partial build

cargo build --release --locked now relies on the default feature-set that each crate enables.
If any binaries (dynamo-run, http, llmctl, metrics, mock_worker) still expect the block-manager or other opt-in features, the build will silently omit them and the resulting binaries may be missing symbols at runtime.

-RUN cargo build --release --locked && \
+RUN cargo build --release --locked --workspace --features dynamo-llm/block-manager && \

Please verify with a clean build that:

1. All five binaries still compile successfully.
2. Integration tests exercising removed python functionality are not compiled in.

---

🏁 Script executed:

#!/bin/bash
# Display workspace section from root Cargo.toml
echo "=== Workspace Section ==="
awk 'BEGIN{in_ws=0} /^\[workspace\]/{in_ws=1} in_ws{print} /^\[/{if(in_ws && !/\[workspace\]/) exit}' Cargo.toml

echo
# Show feature definitions in root Cargo.toml
echo "=== Root Features ==="
grep -R "^features" -n Cargo.toml || echo "No features block in root Cargo.toml"

echo
# Find any 'block-manager' references (feature or code)
echo "=== block-manager Occurrences ==="
rg -n "block-manager" .

Length of output: 2598

---

🏁 Script executed:

#!/bin/bash
# Display first 80 lines of container/Dockerfile.none with line numbers
sed -n '1,80p' -n container/Dockerfile.none | sed = | sed 'N; s/\n/ /'

Length of output: 2123

---

Ignore feature flags for the “none” variant Dockerfile

The container/Dockerfile.none is explicitly the “no-features” build (as indicated by its .none suffix), meant to produce a minimal set of binaries without any optional components. Adding --workspace or --features dynamo-llm/block-manager here would defeat the purpose of this variant. The other Dockerfiles (.sglang, .vllm) already include the appropriate feature flags in their own build stages.

Likely an incorrect or invalid review comment.

lib/bindings/python/rust/engine.rs (1)

204-257: ⚠️ Potential issue

println! leaks to stdout and blocks – use structured logging instead

Inside the hot loop you mix tracing::trace! and a bare println!, which:

1. Bypasses the configured tracing subscriber.
2. Performs a blocking write to stdout for every Python exception.

Replace with tracing::error! to integrate with the existing log pipeline.

-        println!();
-        Python::with_gil(|py| e.display(py));
+        tracing::error!("python exception: {}", e);
+        Python::with_gil(|py| e.display(py));

Likely an incorrect or invalid review comment.