add more cli tests for kubens #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ahmetb merged 4 commits into ahmetb:master from doodlesbykumbi:tests/kubens

Jan 3, 2019

Contributor

doodlesbykumbi commented Jan 3, 2019

No description provided.


          split bats test invocation by executable

07c607c

googlebot added the cla: yes label

This was referenced Jan 3, 2019

split bats test invocation by binary #116

Closed

Add command-line integration tests with bats #2

Closed

Owner

ahmetb commented Jan 3, 2019

I think you pushed to the branch of #116 so I can't merge that now.

Contributor Author

doodlesbykumbi commented Jan 3, 2019 •

edited

Loading

@ahmetb i closed #116 and deleted the branch then created a brand new branch with all the changes. you should be good to merge from here. 1 PR to rule them all :)


          add more cli tests for kubens

ea81c77

doodlesbykumbi force-pushed the tests/kubens branch from 3d30fbc to ea81c77 Compare

January 3, 2019 01:44

ahmetb requested changes

View reviewed changes

kubens Outdated Show resolved Hide resolved

kubens Outdated Show resolved Hide resolved

kubens Outdated Show resolved Hide resolved

mock-kubectl Outdated Show resolved Hide resolved

mock-kubectl Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

mock-kubectl Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

test/common.bash Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

test/kubens.bats Outdated Show resolved Hide resolved

Contributor Author

doodlesbykumbi commented Jan 3, 2019

@ahmetb addressed your comments and replied where it made sense to do so


          clean up kubens tests

1145b9e

doodlesbykumbi force-pushed the tests/kubens branch from 3b3d383 to 1145b9e Compare

January 3, 2019 02:20

ahmetb reviewed

View reviewed changes

test/kubens.bats Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

test/kubens.bats Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

test/mock-kubectl Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

kubens Outdated Show resolved Hide resolved

ahmetb reviewed

View reviewed changes

test/kubens.bats Outdated Show resolved Hide resolved


          small cleanup to kubens tests

f7a193c

ahmetb reviewed

View reviewed changes

test/docker/Dockerfile Outdated Show resolved Hide resolved

doodlesbykumbi force-pushed the tests/kubens branch from 4d3704c to f7a193c Compare

January 3, 2019 17:36

ahmetb approved these changes

View reviewed changes

Owner

ahmetb commented Jan 3, 2019

Thanks these are looking good now! 🙏

ahmetb merged commit 402cc2c into ahmetb:master

doodlesbykumbi deleted the tests/kubens branch

January 3, 2019 18:10

ahmetb added a commit that referenced this pull request


          v0.6.3

10c9bd5

- FIX: Show current context/ns color in interactive (fzf) mode. (#109)
- TEST: Add integration tests for kubectx (#111, #113) and kubens (#105, #117)

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels