Improve HC sync stability #4377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchelli
approved these changes
Jul 5, 2024
happi
approved these changes
Jul 9, 2024
mitchelli
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Make parent chain cache more sync aware * Unbreak eunit tests * Please dialyzer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4373
The parent cache does/did not really cater for the sync case. It filled up in a rather ad hoc way. This change aims to do the (pre-)filling in a more structured way. It also adds a more specific sync-test; though that one passed even before these changes.
What really should be done is to introduce a worker pool like the node sync has; and this pool should synchronize with the child chain sync progress. But since the epochs and periodically sync is coming structural changes will probably be required, so let's kick that one further down the road 😅.
This PR is supported by the Æternity Foundation.