Skip to content

parser: add line number and column to syntax errors #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2023
Merged

parser: add line number and column to syntax errors #71

merged 1 commit into from
Jan 6, 2023

Conversation

paulsmith
Copy link
Contributor

This change adds the line number and column of the position of the syntax error of a parse.

Example, parsing:

^import-

Yields:

1:8: unexpected token type after ^import: -

Address #68

@paulsmith paulsmith requested a review from llimllib January 5, 2023 21:42
llimllib
llimllib approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@llimllib llimllib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@paulsmith paulsmith merged commit ca05e41 into main Jan 6, 2023
@paulsmith paulsmith deleted the 68-parse-errors-line-numbers branch January 6, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@llimllib llimllib llimllib approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsmith @llimllib