proxlight: Freeze adafruit_apds9960 instead of adafruit_hid; enable usb_midi #5329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxlight trinkey is tight on space, but we'd like it to work for both HID and MIDI. It appears that if we freeze the APDS9960 library instead of HID, then sample programs will fit.
Done:
usb_midi, which was previously disabled.adafruit_hid.adafruit_adps9960.The APDS9960 library itself could be reduced by about 500 bytes by shortening and underscoring the command constants, but that doesn't help make anything else fit, so it's not high priority to fix right now.