DecisionTree.ToCode() returns code that compiles #707
Conversation
| @@ -60,7 +60,7 @@ public void Write(DecisionTree tree, string className) | |||
| writer.WriteLine("namespace DecisionTrees"); | |||
| writer.WriteLine("{"); | |||
| writer.WriteLine(" using System.CodeDom.Compiler;"); | |||
| writer.WriteLine(" using System.Collections.Generic;"); | |||
| var csc = new CSharpCodeProvider(); | ||
| var parameters = new CompilerParameters(new[] { "System.dll", "mscorlib.dll" }) {GenerateInMemory = true}; | ||
|
|
||
| var compilerResult = csc.CompileAssemblyFromSource(parameters, tree.ToCode("AccordDecisionTree")); |
There was a problem hiding this comment.
This test only checks that generated code compiles.
|
@cesarsouza Do you need some help to fix CI build for development branch? |
|
Hi @ar7z1, Thanks a lot for the pull request! - and regarding the CI build, indeed I would certainly welcome some help, as I will not have much time to work on it in the next few days. It seems that one of the unit tests are getting stuck after I updated Travis to run the unit tests using NUnit 3 instead of NUnit 2, but I cannot know exactly which test is causing this. I am sure there must be some parameter I could pass to Travis, or some file I could analyze afterwards, but I haven't gotten the chance to investigate it yet. Regards, |
|
Again, thanks a lot for the pull request. Regarding the failing tests, I think I have been able to solve the mystery failing test happening before. Now the problem is some issue with the Accord.Tests.Vision project, as NUnit is not being able to load tests from it properly, for some reason. Regards, |
…) unit test when running in .NET Standardard 2.0 (at least for now). - Updates GH-707
In this PR I fixed #706.