Update to use Zcrypto instead of stdlib crypto for RevocationList #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaomidi
approved these changes
Feb 8, 2023
| @@ -76,7 +75,7 @@ func LintRevocationList(r *ox509.RevocationList) *ResultSet { | |||
| // | |||
| // If registry is nil then the global registry of all lints is used and this | |||
| // function is equivalent to calling LintRevocationListEx(r). | |||
There was a problem hiding this comment.
Thanks to the correction above I realized this should be LintRevocationList(r)
aaomidi
added a commit
that referenced
this pull request
May 5, 2023
* Add the skeleton around linting CRLs * Change the entrypoint of zlint * Add tests for the new skeleton * Address reviews * starting my own suggestions to work coopertaively on he change * Take out generics from the registration struct (#3) * Update to use Zcrypto instead of stdlib crypto for RevocationList (#4) * Take out generics from the registration struct (#3) * updating to use zcrypto * pointing zcrypto back to master * go tidy up --------- Co-authored-by: Amir Omidi <amir@aaomidi.com> * Tidy go mod * Update zcrypto * go mod tidy one more time * Bypass lint for Registry * Add NextUpdate CRL lint (#5) --------- Co-authored-by: christopher-henderson <chris@chenderson.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.