Skip to content

Conversation

MrAnno
Copy link
Member

@MrAnno MrAnno commented Sep 22, 2024

If a partial write occurs, the written messages must be acknowledged.

It is important to note that a message may be written partially.
In that case, the message will be acknowledged once the complete write is successful. If write errors occur during this process, the partially written message may be duplicated.

MrAnno added a commit to MrAnno/axosyslog that referenced this pull request Sep 22, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
@MrAnno MrAnno changed the title file-writer: fix partial write acknowledgements file(), stdout(): fix log sources getting stuck Sep 22, 2024
MrAnno added a commit to MrAnno/axosyslog that referenced this pull request Sep 22, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
@MrAnno MrAnno force-pushed the fix-file-writer-proto branch from 23d2438 to 9614d74 Compare September 22, 2024 16:53
Copy link
Member

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I had one small comment which you can ignore.

Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
If a partial write occurs, the written messages must be acknowledged.

It is important to note that a message may be written partially.
In that case, the message will be acknowledged once the complete write
is successful. If write errors occur during this process, the partially
written message may be duplicated.

Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
@MrAnno MrAnno force-pushed the fix-file-writer-proto branch from 9614d74 to 024ceb9 Compare September 24, 2024 12:46
@MrAnno MrAnno requested a review from alltilla September 24, 2024 12:47
@alltilla alltilla merged commit fcbb8c6 into axoflow:main Sep 24, 2024
22 checks passed
HofiOne pushed a commit to HofiOne/axosyslog that referenced this pull request Mar 13, 2025
Signed-off-by: László Várady <laszlo.varady@anno.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants