Skip to content

[release-0.23] Enable control plane tolerations for Tinkerbell stack components #9972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #9971

/assign rahulbabu95

This change enables the controlPlaneTolerationsEnabled flag for all Tinkerbell
stack components in the values override for the Tinkerbell Helm chart.

When enabled, this flag adds tolerations for the control plane taint
while maintaining a preference for worker nodes through node affinity rules.
This allows the Tinkerbell stack to be scheduled on control plane nodes when
necessary (e.g., when worker nodes are unavailable),
while still preferring worker nodes under normal circumstances.

This change restores the behavior that was present in EKS-A 0.19, where
the Tinkerbell stack could be installed on both control plane and worker
nodes, ensuring better availability during cluster lifecycle operations.

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rahulbabu95
Copy link
Member

/ok-to-test

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2025
@rahulbabu95
Copy link
Member

/lgtm

@rahulbabu95
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-0.23@da820c0). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.23    #9972   +/-   ##
===============================================
  Coverage                ?   69.98%           
===============================================
  Files                   ?      680           
  Lines                   ?    51027           
  Branches                ?        0           
===============================================
  Hits                    ?    35711           
  Misses                  ?    13523           
  Partials                ?     1793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eks-distro-bot eks-distro-bot merged commit 838bcdd into aws:release-0.23 Aug 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants