-
Notifications
You must be signed in to change notification settings - Fork 315
[release-0.23] Enable control plane tolerations for Tinkerbell stack components #9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.23] Enable control plane tolerations for Tinkerbell stack components #9972
Conversation
This change enables the controlPlaneTolerationsEnabled flag for all Tinkerbell stack components in the values override for the Tinkerbell Helm chart. When enabled, this flag adds tolerations for the control plane taint while maintaining a preference for worker nodes through node affinity rules. This allows the Tinkerbell stack to be scheduled on control plane nodes when necessary (e.g., when worker nodes are unavailable), while still preferring worker nodes under normal circumstances. This change restores the behavior that was present in EKS-A 0.19, where the Tinkerbell stack could be installed on both control plane and worker nodes, ensuring better availability during cluster lifecycle operations. Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Hi @eks-distro-pr-bot. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.23 #9972 +/- ##
===============================================
Coverage ? 69.98%
===============================================
Files ? 680
Lines ? 51027
Branches ? 0
===============================================
Hits ? 35711
Misses ? 13523
Partials ? 1793 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #9971
/assign rahulbabu95