Enable control plane tolerations for Tinkerbell stack components #9971
Conversation
This change enables the controlPlaneTolerationsEnabled flag for all Tinkerbell stack components in the values override for the Tinkerbell Helm chart. When enabled, this flag adds tolerations for the control plane taint while maintaining a preference for worker nodes through node affinity rules. This allows the Tinkerbell stack to be scheduled on control plane nodes when necessary (e.g., when worker nodes are unavailable), while still preferring worker nodes under normal circumstances. This change restores the behavior that was present in EKS-A 0.19, where the Tinkerbell stack could be installed on both control plane and worker nodes, ensuring better availability during cluster lifecycle operations. Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
f1f3b87 to
f326744
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9971 +/- ##
==========================================
+ Coverage 69.96% 69.98% +0.02%
==========================================
Files 680 680
Lines 51000 51148 +148
==========================================
+ Hits 35684 35798 +114
- Misses 13522 13551 +29
- Partials 1794 1799 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/cherrypick release-0.23 |
|
/cherrypick release-0.22 |
|
@rahulbabu95: new pull request created: #9972 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rahulbabu95: new pull request created: #9973 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
This change enables the controlPlaneTolerationsEnabled flag for all Tinkerbell stack components in the values override for the Tinkerbell Helm chart.
When enabled, this flag adds tolerations for the control plane taint while maintaining a preference for worker nodes through node affinity rules. This allows the Tinkerbell stack to be scheduled on control plane nodes when necessary (e.g., when worker nodes are unavailable), while still preferring worker nodes under normal circumstances.
This change restores the behavior that was present in EKS-A 0.19, where the Tinkerbell stack could be installed on both control plane and worker nodes, ensuring better availability during cluster lifecycle operations.
Testing (if applicable):
Built cli and controller and ran a upgrade to new stack while making the worker node unavailable. Observed Tink stack getting scheduled on the worker nodes.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.