Skip to content

Conversation

snarkychef
Copy link
Member

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2658

Description of changes:
Documentation changes for new cilium cniExclusive field in cniConfig, which can be used to deploy other cni alongside cilium.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@snarkychef snarkychef mentioned this pull request Jul 25, 2025
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2025
@parlakisik
Copy link
Contributor

/lgtm

@eks-distro-bot
Copy link
Collaborator

@parlakisik: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.98%. Comparing base (594ec88) to head (39314ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9952   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         680      680           
  Lines       51148    51148           
=======================================
  Hits        35798    35798           
  Misses      13551    13551           
  Partials     1799     1799           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snarkychef snarkychef force-pushed the docs-support-external-cni branch from 051c4e8 to 3b86159 Compare July 25, 2025 22:55
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2025
@snarkychef snarkychef force-pushed the docs-support-external-cni branch from 3b86159 to a6c0939 Compare July 25, 2025 23:06
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2025
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisnegus chrisnegus merged commit a0f535e into aws:main Aug 5, 2025
7 of 8 checks passed
@snarkychef
Copy link
Member Author

/cherry-pick release-0.23

@eks-distro-pr-bot
Copy link
Contributor

@snarkychef: new pull request created: #9977

In response to this:

/cherry-pick release-0.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants