Skip to content

[release-0.22] Fix hardware application sequence in Tinkerbell upgrade flow #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

[release-0.22] Fix hardware application sequence in Tinkerbell upgrade flow #9882

merged 1 commit into from
Jul 2, 2025

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #9880

/assign rahulbabu95

Fix hardware application sequence in Tinkerbell upgrade flow
65ad4a7 
There is an issue in the EKS-A bare metal upgrade flow where hardware was being applied with a new schema before the CRDs were updated, causing validation failures.

Key changes:
- Move hardware application logic from SetupAndValidateUpgradeCluster to PreCoreComponentsUpgrade to ensure hardware is applied after CRDs are updated
- Remove redundant PostBootstrapSetupUpgrade and PostBootstrapDeleteForUpgrade methods from the provider interface and all provider implementations

This change ensures the correct sequence: first update CRDs, then apply hardware with the new schema.

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request Jul 2, 2025
Merged
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2025
@rahulbabu95
Copy link
Member

/ok-to-test
/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-0.22@734b696). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             release-0.22    #9882   +/-   ##
===============================================
  Coverage                ?   69.87%           
===============================================
  Files                   ?      672           
  Lines                   ?    49815           
  Branches                ?        0           
===============================================
  Hits                    ?    34807           
  Misses                  ?    13221           
  Partials                ?     1787

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eks-distro-bot eks-distro-bot merged commit 04cd7ec into aws:release-0.22 Jul 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rahulbabu95 rahulbabu95

Labels
approved lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eks-distro-pr-bot @eks-distro-bot @rahulbabu95