Fix hardware application sequence in Tinkerbell upgrade flow #9880
Conversation
There is an issue in the EKS-A bare metal upgrade flow where hardware was being applied with a new schema before the CRDs were updated, causing validation failures. Key changes: - Move hardware application logic from SetupAndValidateUpgradeCluster to PreCoreComponentsUpgrade to ensure hardware is applied after CRDs are updated - Remove redundant PostBootstrapSetupUpgrade and PostBootstrapDeleteForUpgrade methods from the provider interface and all provider implementations This change ensures the correct sequence: first update CRDs, then apply hardware with the new schema. Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9880 +/- ##
==========================================
+ Coverage 69.90% 69.94% +0.04%
==========================================
Files 676 676
Lines 50456 50427 -29
==========================================
Hits 35271 35271
+ Misses 13377 13350 -27
+ Partials 1808 1806 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/cherrypick release-0.23 |
|
/cherrypick release-0.22 |
|
@rahulbabu95: new pull request created: #9881 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rahulbabu95: new pull request created: #9882 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
There is an issue in the EKS-A bare metal upgrade flow where hardware was being applied with a new schema before the CRDs were updated, causing validation failures.
Key changes:
The issue was occurring because hardware was being generated and applied based on a new schema in the upgrade flow before the CRDs were actually updated, resulting in validation errors with messages like
unknown field 'spec.connection.providerOptions.preferredOrder'.This change ensures the correct sequence: first update CRDs, then apply hardware with the new schema.
Testing (if applicable):
Manually tested upgrade with above changes and the flow doesn't break.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.