[timeseries] enable logging to file, clean up set_logger_verbosity calls #3877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shchur
approved these changes
Jan 23, 2024
a345cda to
d07a942
Compare
|
Job PR-3877-d07a942 is done. |
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3766
Description of changes:
TabularPredictor.Note: Previously, timeseries model objects (
AbstractTimeSeriesModel) had their own verbosity levels provided in the call tofit, which was propagated from the Trainerfitcall to individual models. While this created clutter, it also afforded the flexibility of models potentially using the verbosity level to set dependency log output levels (e.g., GluonTS). We keep this as is: GluonTS models still receiveverbosityas a fit argument.However, logger verbosity is now only controlled by the Predictor, which sets the verbosity (either during init or fit) to the
autogluon.timeseriesparent logger, which is inherited by alllogging.getLogger(__name__)calls in the timeseries module.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.