Skip to content

Conversation

Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 20, 2023

Issue #, if available:

Description of changes:

  • Move PyMuPDF to optional
    Since PyMuPDF isn't available in Conda, better to move to an optional dependency as it is only used in a specific scenario for PDF file reading.

TODO:

  • Merge into master
  • Merge diff into branch 0.8.0 -> use this for conda release, don't use master

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added this to the 0.8 Release milestone Jun 20, 2023
Copy link
Contributor

@cheungdaven cheungdaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Jun 20, 2023
@github-actions
Copy link

Job PR-3331-81b994f is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3331/81b994f/index.html

@github-actions
Copy link

Job PR-3331-2b439f0 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3331/2b439f0/index.html

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhiqiangdon zhiqiangdon merged commit 2de3105 into autogluon:master Jun 21, 2023
yinweisu pushed a commit to yinweisu/autogluon that referenced this pull request Jun 21, 2023
Co-authored-by: Zhiqiang Tang <zhiqiang.tang@rutgers.edu>
yinweisu pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Nick Erickson <neerick@amazon.com>
Co-authored-by: Zhiqiang Tang <zhiqiang.tang@rutgers.edu>
ddelange added a commit to ddelange/autogluon that referenced this pull request Jun 22, 2023
* 'master' of https://github.com/awslabs/autogluon:
  [AutoMM] Remove fairscale (autogluon#3342)
  lint core (autogluon#3339)
  Move PyMuPDF to optional (autogluon#3331)
  Add community section to website front page (autogluon#3333)
  lint common (autogluon#3337)
  Remove TIMM in core setup (autogluon#3334)
  Update persist_models max_memory 0.1 -> 0.4 (autogluon#3338)
  Update google analytics property (autogluon#3330)
  Add Discord Link (autogluon#3332)
  0.8 post release (autogluon#3322)
@Innixma Innixma deleted the move_PyMuPDF_to_optional branch April 16, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants