[tabular] Improve LightGBM memory estimate #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-5101-a5612fb is done. |
prateekdesai04
approved these changes
Apr 29, 2025
suzhoum
approved these changes
Apr 30, 2025
| if available_mb != 0: | ||
| model_size_memory_ratio = estimated_model_size_mb / available_mb | ||
| else: | ||
| model_size_memory_ratio = 100 |
There was a problem hiding this comment.
Maybe semantically we can have a better way than assigning it to 100? But I'm fine with it as 100 is a large enough number for thresholding.
There was a problem hiding this comment.
Yeah, having a separate flag to flip for that would be logically a bit cleaner, but I wanted to ensure that whatever I did here had the lowest possible chance of introducing a bug.
tonyhoo
approved these changes
Apr 30, 2025
FireballDWF
pushed a commit
to FireballDWF/autogluon
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.