-
Notifications
You must be signed in to change notification settings - Fork 1.1k
upgrade numpy to 2.x with latest catboost release #5072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/platform_tests b76f8cf |
Job PR-5072-b76f8cf is done. |
/benchmark b76f8cf module=tabular preset=tabular_best benchmark=tabular_full time_limit=8h Benchmark Test Result - Fail Evaluation Results Path: s3://autogluon-ci-benchmark/evaluation/tabular/numpy |
Noticed below list of errors from the benchmark run |
There were also many failures in the benchmark but not enough error messages presented in the logs. I'll probably run a few benchmarks locally to see if I can find anything. |
/benchmark b76f8cf module=tabular preset=tabular_best benchmark=tabular_small time_limit=1h Benchmark Test Result - Fail Evaluation Results Path: s3://autogluon-ci-benchmark/evaluation/tabular/numpy |
Job PR-5072-3deb4c2 is done. |
Job PR-5072-5f8bd20 is done. |
After some digging, I think the root cause is due to inconsistent numpy versions used in automlbenchmark evaluation and virtual env created for AutoGluon feature branch for training. I created a PR Innixma/automlbenchmark#12 to upgrade numpy in our custom automlbenchmark branch. |
/benchmark b76f8cf module=tabular preset=tabular_best benchmark=tabular_full time_limit=1h |
/benchmark b76f8cf module=tabular preset=tabular_best benchmark=tabular_full time_limit=1h Benchmark Test Result - Pass Evaluation Results Path: s3://autogluon-ci-benchmark/evaluation/tabular/numpy |
/platform_tests 5f8bd20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Job PR-5072-ca062d5 is done. |
Co-authored-by: Su Zhou <zhousu@amazon.com>
Co-authored-by: Su Zhou <zhousu@amazon.com>
Issue #, if available:
catboost/catboost#2671
Description of changes:
With the release of catboost 1.2.8 and resolution of the issue, update numpy support on autogluon side
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.