Skip to content

[AutoMM] Fix pdf classficiation tutorial #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2024
Merged

[AutoMM] Fix pdf classficiation tutorial #4127

merged 3 commits into from
Apr 24, 2024

Conversation

zhiqiangdon
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Fixed the missing installation command in the Colab notebook.
  2. Removed developer's local environment info from the notebook.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@zhiqiangdon zhiqiangdon added the model list checked You have updated the model list after modifying multimodal unit tests/docs label Apr 23, 2024
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
pydantic_core==2.18.1 pydantic_core==2.18.2
pydantic==2.7.0 pydantic==2.7.1
platformdirs==4.2.0 platformdirs==4.2.1
virtualenv==20.25.3 virtualenv==20.26.0
pydantic_core==2.18.1 pydantic_core==2.18.2
pydantic==2.7.0 pydantic==2.7.1
platformdirs==4.2.0 platformdirs==4.2.1
virtualenv==20.25.3 virtualenv==20.26.0

prateekdesai04
prateekdesai04 reviewed Apr 23, 2024
View reviewed changes
docs/tutorials/multimodal/document_prediction/pdf_classification.ipynb
},
"orig_nbformat": 4
"name": "python"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we remove the version specification?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version would depend on the running environment. Users may try it in different versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work on all the versions?

Copy link
Contributor Author

@zhiqiangdon zhiqiangdon Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removing the specific version is to be compatible to all versions.

@github-actions GitHub Actions
Copy link

Job PR-4127-fb47d67 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4127/fb47d67/index.html

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.89 botocore==1.34.90
boto3==1.34.89 boto3==1.34.90
botocore==1.34.89 botocore==1.34.90
boto3==1.34.89 boto3==1.34.90

prateekdesai04
prateekdesai04 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@prateekdesai04 prateekdesai04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

Job PR-4127-25f4275 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4127/25f4275/index.html

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@zhiqiangdon zhiqiangdon merged commit d972340 into autogluon:master Apr 24, 2024
@github-actions GitHub Actions
Copy link

Job PR-4127-4079ff7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4127/4079ff7/index.html

@zhiqiangdon zhiqiangdon deleted the tutorial branch April 24, 2024 22:49
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
@zhiqiangdon @LennartPurucker
[AutoMM] Fix pdf classficiation tutorial (autogluon#4127)
249965d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekdesai04 prateekdesai04 prateekdesai04 approved these changes

@tonyhoo tonyhoo Awaiting requested review from tonyhoo

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangdon @yinweisu @prateekdesai04