Skip to content

Fix tensorrt notebook failure #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2024
Merged

Fix tensorrt notebook failure #4113

merged 4 commits into from
Apr 18, 2024

Conversation

tonyhoo
Copy link
Contributor

@tonyhoo tonyhoo commented Apr 17, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@tonyhoo tonyhoo added module: multimodal model list checked You have updated the model list after modifying multimodal unit tests/docs run-multi-gpu Run multimodal multi-gpu tests labels Apr 17, 2024
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.85 botocore==1.34.86
boto3==1.34.85 boto3==1.34.86
botocore==1.34.85 botocore==1.34.86
boto3==1.34.85 boto3==1.34.86

@github-actions GitHub Actions
Copy link

Job PR-4113-6fcdb41 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4113/6fcdb41/index.html

@tonyhoo tonyhoo changed the title [WIP] fix tensorrt notebook failure Fix tensorrt notebook failure Apr 17, 2024
suzhoum
suzhoum reviewed Apr 17, 2024
View reviewed changes
docs/tutorials/multimodal/advanced_topics/tensorrt.ipynb Outdated
@@ -56,6 +56,7 @@
" print(f\"tensorrt=={tensorrt.__version__}, onnx=={onnx.__version__}, onnxruntime=={onnxruntime.__version__}\")\n",
"except ImportError:\n",
" !pip install autogluon.multimodal[tests]\n",
" !pip install -U --pre tensorrt\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can we add a TODO to this line so that we can monitor to have it removed in case the pre-release version breaks in future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not best practice to introduce TODO item in external facing doc. I have pin the version while creating a tracking issue to keep it on our radar

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@github-actions GitHub Actions
Copy link

Job PR-4113-7f97bee is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4113/7f97bee/index.html

@tonyhoo tonyhoo merged commit f269d65 into autogluon:master Apr 18, 2024
tonyhoo added a commit that referenced this pull request Apr 18, 2024
@tonyhoo
Fix tensorrt notebook failure (#4113)
8fa0595
tonyhoo added a commit that referenced this pull request Apr 18, 2024
@tonyhoo
Fix tensorrt notebook failure (#4113)
4825cff
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
@tonyhoo @LennartPurucker
Fix tensorrt notebook failure (autogluon#4113)
549e685
@tonyhoo tonyhoo deleted the trt_fix branch July 31, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzhoum suzhoum suzhoum approved these changes

Assignees
No one assigned
Labels
model list checked You have updated the model list after modifying multimodal unit tests/docs module: multimodal run-multi-gpu Run multimodal multi-gpu tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyhoo @yinweisu @suzhoum