Skip to content

[timeseries] Fix logger messages if series are all NaN #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2024
Merged

[timeseries] Fix logger messages if series are all NaN #4068

merged 2 commits into from
Apr 9, 2024

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented Apr 9, 2024

Description of changes:

  • Avoid printing the following error message when dummy forecast is used for all-NaN series
Warning: SeasonalNaive/W0 failed for 1 time series (50%). Fallback model SeasonalNaive was used for these time series

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shchur shchur requested a review from canerturkmen April 9, 2024 10:09
@yinweisu
Copy link
Contributor

yinweisu commented Apr 9, 2024

Previous CI Run Current CI Run
optimum==1.18.0 optimum==1.18.1
optimum==1.18.0 optimum==1.18.1

canerturkmen
canerturkmen approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shchur shchur merged commit 2cc5cca into autogluon:master Apr 9, 2024
@shchur shchur deleted the fix-edge-cases branch April 9, 2024 11:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Job PR-4068-ee6e51e is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4068/ee6e51e/index.html

LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
@shchur @LennartPurucker
[timeseries] Fix logger messages if series are all NaN (autogluon#4068)
c3ec2c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canerturkmen canerturkmen canerturkmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shchur @yinweisu @canerturkmen