[timeseries] Fix windows platform tests logfile permission error #4041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/platform_tests ref=ts_platform_test_fix |
|
canerturkmen
approved these changes
Apr 5, 2024
|
Remaining errors in timeseries windows platform tests are coming from |
|
Job PR-4041-6751935 is done. |
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Windows platform tests for
timeseriesare failing due to a permission error on removing a logfile that is being used by another process.Description of changes:
This was introduced due to changes made in #3934 specifically these two lines were added to clean up the test directory (see comment: https://github.com/autogluon/autogluon/pull/3934/files#r1495459186). So this is a test specific fix for windows, and we skip removing the custom_log file in windows tests.:
autogluon/timeseries/tests/unittests/test_predictor.py
Lines 1090 to 1091 in 4de3056
Thanks @shchur for helping setup the machine and sharing some context on the issue.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.