Skip to content

Conversation

canerturkmen
Copy link
Contributor

Issue #, if available:

Description of changes:

Adds methods to persist predictor, learner, trainer and model objects, bringing the ability to persist models in memory like in TabularPredictor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@canerturkmen canerturkmen added the module: timeseries related to the timeseries module label Mar 25, 2024
@canerturkmen canerturkmen added this to the 1.1 Release milestone Mar 25, 2024
@canerturkmen canerturkmen requested a review from shchur March 25, 2024 19:04
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nitpicks. Also need to check what's happening with the tests

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

Copy link

Job PR-4005-5cfc886 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4005/5cfc886/index.html

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

assert len(predictor._learner.load_trainer().models) == 0


def _add_ensemble_to_predictor(predictor, hyperparameters, make_best_model=True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.71 botocore==1.34.72
boto3==1.34.71 boto3==1.34.72
botocore==1.34.71 botocore==1.34.72
boto3==1.34.71 boto3==1.34.72

@canerturkmen canerturkmen merged commit 364ccfc into autogluon:master Mar 27, 2024
@canerturkmen canerturkmen deleted the add-persist branch March 27, 2024 21:49
Copy link

Job PR-4005-8d853eb is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4005/8d853eb/index.html

LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: timeseries related to the timeseries module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants