Skip to content

Prevent defining ASPEC::TestCase#initialize methods that accepts arguments/blocks #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

Prevent defining ASPEC::TestCase#initialize methods that accepts arguments/blocks #516

merged 2 commits into from
Feb 5, 2025

Conversation

Blacksmoke16
Copy link
Member

Context

These methods must not accept parameters so some internal implementation details work as expected.

Resolves #515

Changelog

  • Prevent defining ASPEC::TestCase#initialize methods that accepts arguments/blocks

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected component:spec labels Feb 5, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 18.55% <57.14%> (+0.01%) ⬆️
unit 96.62% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.09% <ø> (ø)
dependency_injection 97.89% <ø> (ø)
dotenv 98.58% <ø> (ø)
event_dispatcher 95.46% <ø> (ø)
framework 98.13% <100.00%> (+<0.01%) ⬆️
image_size 96.63% <ø> (ø)
mercure 94.95% <ø> (ø)
mime 98.56% <ø> (ø)
negotiation 97.94% <ø> (ø)
routing 98.39% <ø> (ø)
serializer 96.51% <ø> (ø)
spec 96.40% <100.00%> (+0.10%) ⬆️
validator 95.87% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit 0d29ec4 into master Feb 5, 2025
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the disallow-test-case-args branch February 5, 2025 16:27
PallasAthenaie pushed a commit to athena-framework/framework that referenced this pull request Feb 5, 2025
@Blacksmoke16
Prevent defining ASPEC::TestCase#initialize methods that accepts ar…
cd3c1a8 
…guments/blocks (athena-framework/athena#516)
PallasAthenaie pushed a commit to athena-framework/spec that referenced this pull request Feb 5, 2025
@Blacksmoke16
Prevent defining ASPEC::TestCase#initialize methods that accepts ar…
e980368 
…guments/blocks (athena-framework/athena#516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component:spec kind:bug An existing feature isn't working as expected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid memory access when running a test case registered a service while not providing any arguments
1 participant
@Blacksmoke16