Param refactor #426
Merged
Param refactor #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Aug 23, 2024
* Remove `ATHA::QueryParam` and `ATHA::RequestParam` * Remove `ATH::Exception::InvalidParamete` * Remove everything in `ATH::Params` namespace, including `ATH::Action#params` * Add `ATH::Exception.from_status`
This was referenced Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The previous implementation of param support (query and request) was essentially a one-off, and dates back to the early years of the framework. This PR brings the feature into more modern patterns, and makes everything much less complex.
Resolves #418
Changelog
ATHA::QueryParamATHA::RequestParamATH::Exception::InvalidParameterATH::Paramsnamespace, includingATH::Action#paramsATH::Listeners::ParamFetcherATH::Exception.from_statushelper methodATHA::MapQueryParameterfor handling query parameters