Blosc2 USE ON: Fix Module Fallback #3774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid that for older C-Blosc2 releases, the search logic errors out after the config module was not found.
vicentebolea
approved these changes
Aug 24, 2023
Merged
dmitry-ganyushin
added a commit
to dmitry-ganyushin/ADIOS2
that referenced
this pull request
Nov 1, 2023
* master: (183 commits) Adding tests for writing null blocks with and without compression Replace LookupWriterRec's linear search on RecList with an unordered_map. For 250k variables, time goes from 21sec to ~1sec in WSL. The order of entries in RecList was not necessary for the serializer to work correctly. Merge pull request ornladios#3805 from pnorbert/fix-bpls-string-scalar Merge pull request ornladios#3804 from pnorbert/fix-aws-version Merge pull request ornladios#3759 from pnorbert/bp5dbg-metadata new attempt to commit query support of local array. (ornladios#3868) MPI::MPI_Fortran should be INTERFACE not PUBLIC Fix hip example compilation error (ornladios#3865) Server Improvements (ornladios#3862) ascent,ci: remove unshallow flag Remove Slack as a contact mechanism (ornladios#3866) bug fix: syntax error in json output (ornladios#3857) Update the bpWriterReadHip example's cmake to run on crusher Examples: Use BPFile instead of BP3/4/5 for future-proof inlineMWE example: Close files at the end Examples: Add BeginStep/EndStep wherever it was missing BP5Serializer: handle local variables that use operators (ornladios#3859) Blosc2 USE ON: Fix Module Fallback (ornladios#3774) SST,MPI,DP: soft handle peer error SST,MPI,DP: improve uniq identifier Fix destdir install test (ornladios#3850) cmake: include ctest before detectoptions ci: enable tau check Add/Improve the ReadMe.md files in examples directory Disable BUILD_TESTING and ADIOS2_BUILD_EXAMPLES by default Remove testing based on ADIOS2-examples Fix formatting issue in DetectOptions.cmake Add examples from ADIOS2-Examples Improve existing examples MPI_DP: do not call MPI_Init (ornladios#3847) cmake: update minimum cmake to 3.12 (ornladios#3849) MPI: add timeout for conf test for MPI_DP (ornladios#3848) Tweak Remote class and test multi-threaded file remote access (ornladios#3834) Add prototype testing of remote functionality (ornladios#3830) Try always using the MPI version Try always using the MPI version Import tests from bp to staging common, implement memory selection in SST ci: fix codeql ignore path (ornladios#3772) install: export adios2 device variables (ornladios#3819) added support to query BP5 files (ornladios#3809) ffs 2023-09-19 (67e411c0) Fix abs/rel step in BP5 DoCount fix dummy Win build Pass Array Order of reader to remote server for proper Get() operation Fix the ADIOS_USE_{_} variable names to use ADIOS2 Remove BP5 BetweenStepPairs variable that hides Engine.h counterpart Delete experimental examples yaml-cpp: support 0.8.0 version Mod not to overload to make some compilers happy Mod to keep MinBlocksInfo private to BP5Writer, not reuse Engine.h API. gha,ci: update checkout to v4 Limit testing changes to BP5 tests: fix windows 64bit type issues Add location of hdf5.dll to PATH for windows tests Fix more compiler warnings from ompi build clang format Fix size_t -> int conversion warnings Allow building with Visual Studio and HDF5 shared libs Fixup local var reading by block with test, master branch use documented initial cache variable to find hdf5 on windows ci: Add HDF5 to a windows build Remove unused SelectionType values Update ADIOS2 HDF5 VOL with basic set of capability flags defines reorder Remove file before writing, catch exceptions format Reader-side Profiling removed a comment ci: disable MGARD static build cmake: fix ffs dependency removed comments and cleaned up more code bp5: remove ADIOS2_USE_BP5 option operators: fix module library ci: Create static minimal build cmake: correct prefer_shared_blosc behavior removing warning from auto clang-format match type of timestep for h5 engine to size_t (same as adios VariableBase class) when storing to hdf5, check the limit of size_t and match to the right type (uint, ulong, default ulonglong) BP5Deserialize: modify changes to keep abi compt Rename test. fix windows compile errors. add codeql workflow Fix ChunkV maintaining CurOffset when downsizing current chunk in Allocate() and creating the next chunk. ci: fix docker images names removed kwsys gitattributes KWSys 2023-05-25 (c9f0da47) fixup! ci: add mgard dependency to spack builds ci: remove unused script part cmake: remove redundant pugixml dependency ci: add mgard dependency to spack builds cmake: Remove enet config warning cmake: resolve cmake python deprecation enet 2023-08-15 (7587eb15) EVPath 2023-08-15 (657c7fa4) dill 2023-08-15 (235dadf0) atl 2023-08-15 (7286dd11) remove data.py since BP5 data file has no format format bp5dbg parse records and check sizes during it for mmd.0 and md.0. No decoding FFS records. cmake: correct info.h installation path ...
pnorbert
added a commit
to pnorbert/ADIOS2
that referenced
this pull request
Nov 20, 2023
* master: (126 commits) ReadMe.md: Mention 2.9.2 release Cleanup server output a bit (ornladios#3914) ci: set openmpi and openmp params Example using Kokkos buffers with SST Changes to MallocV to take into consideration the memory space of a variable Change install directory of Gray scott files again ci,crusher: increase supported num branches ci: add shellcheck coverage to source and testing Change install directory of Gray scott files Only rank 0 should print the initialization message in perfstub Defining and computing derived variables (ornladios#3816) Add Remote "-status" command to see if a server is running and where (ornladios#3911) examples,hip: use find_package(hip) once in proj Add Steps Tutorial Add Operators Tutorial Add Attributes Tutorial Add Variables Tutorial Add Hello World Tutorial Add Tutorials' Download and Build section Add Tutorials' Overview section Improve bpStepsWriteRead* examples Rename bpSZ to bpOperatorSZWriter Convert bpAttributeWriter to bpAttributeWriteRead Improve bpWriter/bpReader examples Close file after reading for hello-world.py Fix names of functions in engine Fix formatting warnings Add dataspaces.rst in the list of engines Add query.rst cmake: find threads package first docs: update new_release.md Bump version to v2.9.2 ci: update number of task for mpich build clang-format: Correct format to old style Merge pull request ornladios#3878 from anagainaru/test-null-blocks Merge pull request ornladios#3588 from vicentebolea/fix-mpi-dp Adding tests for writing null blocks with and without compression bp5: make RecMap an static anon namespaced var Replace LookupWriterRec's linear search on RecList with an unordered_map. For 250k variables, time goes from 21sec to ~1sec in WSL. The order of entries in RecList was not necessary for the serializer to work correctly. Replace LookupWriterRec's linear search on RecList with an unordered_map. For 250k variables, time goes from 21sec to ~1sec in WSL. The order of entries in RecList was not necessary for the serializer to work correctly. (ornladios#3877) Fix data length calculation for hash (ornladios#3875) Merge pull request ornladios#3823 from eisenhauer/SstMemSel Merge pull request ornladios#3805 from pnorbert/fix-bpls-string-scalar Merge pull request ornladios#3804 from pnorbert/fix-aws-version Merge pull request ornladios#3759 from pnorbert/bp5dbg-metadata new attempt to commit query support of local array. (ornladios#3868) MPI::MPI_Fortran should be INTERFACE not PUBLIC Fix hip example compilation error (ornladios#3865) Server Improvements (ornladios#3862) ascent,ci: remove unshallow flag Remove Slack as a contact mechanism (ornladios#3866) bug fix: syntax error in json output (ornladios#3857) Update the bpWriterReadHip example's cmake to run on crusher Examples: Use BPFile instead of BP3/4/5 for future-proof inlineMWE example: Close files at the end Examples: Add BeginStep/EndStep wherever it was missing BP5Serializer: handle local variables that use operators (ornladios#3859) gha,ci: update checkout to v4 Blosc2 USE ON: Fix Module Fallback cmake: correct prefer_shared_blosc behavior cmake: correct info.h installation path ci: disable MGARD static build operators: fix module library ci: add downloads readthedocs cmake: Add Blosc2 2.10.1 compatibility. Blosc2 USE ON: Fix Module Fallback (ornladios#3774) Fix destdir install test (ornladios#3850) cmake: update minimum cmake to 3.12 (ornladios#3849) MPI: add timeout for conf test for MPI_DP (ornladios#3848) MPI_DP: do not call MPI_Init (ornladios#3847) install: export adios2 device variables (ornladios#3819) Merge pull request ornladios#3799 from vicentebolea/support-new-yaml-cpp Merge pull request ornladios#3737 from vicentebolea/fix-evpath-plugins-path SST,MPI,DP: soft handle peer error SST,MPI,DP: improve uniq identifier Fix destdir install test (ornladios#3850) cmake: include ctest before detectoptions ci: enable tau check Add/Improve the ReadMe.md files in examples directory Disable BUILD_TESTING and ADIOS2_BUILD_EXAMPLES by default Remove testing based on ADIOS2-examples Fix formatting issue in DetectOptions.cmake Add examples from ADIOS2-Examples Improve existing examples MPI_DP: do not call MPI_Init (ornladios#3847) cmake: update minimum cmake to 3.12 (ornladios#3849) MPI: add timeout for conf test for MPI_DP (ornladios#3848) Tweak Remote class and test multi-threaded file remote access (ornladios#3834) Add prototype testing of remote functionality (ornladios#3830) Try always using the MPI version Try always using the MPI version Import tests from bp to staging common, implement memory selection in SST ci: fix codeql ignore path (ornladios#3772) install: export adios2 device variables (ornladios#3819) added support to query BP5 files (ornladios#3809) Partial FFS Upstream, only changes to type_id ffs 2023-09-19 (67e411c0) Fix abs/rel step in BP5 DoCount fix dummy Win build Pass Array Order of reader to remote server for proper Get() operation ...
vicentebolea
pushed a commit
to vicentebolea/ADIOS2
that referenced
this pull request
Jan 7, 2025
Code extracted from:
https://github.com/pybind/pybind11.git
at commit 58c382a8e3d7081364d2f5c62e7f429f0412743b (stable).
Upstream Shortlog
-----------------
Aaron Gokaslan (7):
6f01c60a Improve Python 3.11 support (ornladios#3694)
45219c6b fix: potential memory leak in pypy (ornladios#3774)
dd617dec fix: missing move in eval.h (ornladios#3775)
251516bc Cleanup casters to release none() to avoid ref counting (ornladios#4269)
305c4711 fix: Revert pfect args make iterator (ornladios#4234)
5b395c9b fix: improve bytes to str decoding error handling (ornladios#4294)
a491af61 bugfix: delete proper ctors in gil.h (ornladios#4490)
Chekov2k (1):
15fde1de Add `PYBIND11_SIMPLE_GIL_MANAGEMENT` option (cmake, C++ define) (ornladios#4216)
Chris Ohk (1):
5327c199 docs: Correct minor typos (ornladios#3721)
DWesl (1):
a4f6627d docs: clarify requirements for including pybind11 (#5326)
Eli Schwartz (1):
882cb769 add --version option to pybind11-config (ornladios#4526)
Eric Cousineau (1):
93d68dd9 cast: Qualify symbol usage in PYBIND11_TYPE_CASTER (ornladios#3758)
Ethan Steinberg (2):
2de6e398 [v2.10] Revert the addition of the GIL check feature (ornladios#4432)
e414c4bd fix: improve the error reporting for inc_ref GIL failures (ornladios#4427)
Henry Schreiner (37):
8c859e48 fix: minor CMake warning fix for unused variable (ornladios#3718)
80589625 ci: fix PyPy (ornladios#3768)
5c2b53b5 chore: bump changelog for 2.9.2 (ornladios#3834)
914c06fb chore: set to version 2.9.2
412918d1 feat: add entrypoint for cmake modules dir (ornladios#4258)
a8f21107 docs: update changelog (ornladios#4265)
eaa5f7bd Revert "feat: add entrypoint for cmake modules dir" (ornladios#4270)
0e82c360 fix: add flag for overriding classic Python search values (ornladios#4195)
738a6f83 ci: move to final release of 3.11 (ornladios#4286)
f2ee641e docs: prepare for 2.10.1 release (ornladios#4279)
80dc998e chore: bump versions for 2.10.1
0bd8896a chore: prepare for 2.10.3 (ornladios#4437)
993eb2b6 chore: update to black 23 (ornladios#4482)
1cae8dc0 fix: tests dir has started to show up in packaging (ornladios#4510)
f5cff4f2 fix: nicer stack level for warning (ornladios#4516)
3f5a7e55 docs: changelog for 2.10.4 (ornladios#4532)
5b0a6fc2 chore: bump version to 3.10.4
63020d33 docs: prepare for 2.13.1 (#5203)
941f45bc chore: prepare for 2.13.1
f50830ea tests: run on pyodide (#4745)
d8fcfe34 fix(cmake): add required emscripten flags (#5298)
6d5704cd docs: prepare for 2.13.2 (#5299)
07f30430 chore: prepare for 2.13.2
835139f5 fix: emscripten cmake issue (#5301)
45eaee91 fix: quote paths from pybind11-config (#5302)
7662af69 docs: prepare for 2.13.3
bd676436 chore: prepare for 2.13.3
75c11769 Revert "fix: quote paths from pybind11-config (#5302)" (#5309)
63b0d146 docs: prepare for 2.13.4 (#5312)
c6239a8a chore: version 2.13.4
b0050f30 fix: never use `..` in a header include (#5321)
0d21cadc fix: allow -Wpedantic in C++20 mode (#5322)
b3f5f2e7 docs: prepare for 2.13.5 (#5327)
7c33cdc2 chore: prepare for 2.13.5
7b67d8e9 docs: update changelog for 2.13.6 (#5372)
e445ca2b ci: PyPI attestations (#5374)
a2e59f0e chore: bump to 2.13.6
Lalaland (1):
ce63bcb9 Fix casts to void* (ornladios#4275)
Markus Bauer (1):
973a16e9 fix: escape paths with spaces in pybind11-config (#4874)
Michael Carlstrom (3):
dd0e4a0b feat(types): add support for Typing.Callable Special Case (#5202)
65afa13e fix: add guard for GCC <10.3 on C++20 (#5205)
a4dd41a1 feat(types) Adds special Case for empty C++ tuple type annotation (#5214)
Mike Essenmacher (1):
1f4cf8fe Replace "whitelist" with "allowlist" (ornladios#4506)
ObeliskGate (2):
ff3ca786 fix: `<ranges>` support for `py::tuple` and `py::list` (#5314)
b9f85757 fix: using `__cpp_nontype_template_args` instead of `__cpp_nontype_template_parameter_class` (#5330)
Ralf Gommers (1):
b4307453 docs: extend `PYBIND11_MODULE` documentation, mention `mod_gil_not_used` (#5250)
Ralf W. Grosse-Kunstleve (16):
895fc663 ci: update PGI build (old one no longer signed) (ornladios#4260)
3fb36a99 fix: unicode surrogate character in Python exception message. (ornladios#4297)
0abe64c5 Fix `detail::obj_class_name()` to work correctly for meta classes. (ornladios#4436)
050de893 ci: remove clang 10 C++20 (it broke recently) (ornladios#4438)
f14bb03d Add clang15 C++20 job (ornladios#4443)
4f6183cf Ensure `import pybind11_tests` traceback is shown. (ornladios#4455)
5ece09ad Resolve new flake8 error (ornladios#4462)
c0e2eeba Bump isort version to 5.12.0 (ornladios#4480)
c773a02a Appease new flake8 B028 error: (ornladios#4513)
9a1eeed0 Make warning suppressions MINGW-specific again. (ornladios#4515)
2965fa8d Preparation for v2.11.1 patch release (#4752)
8a099e44 Fix version number mishap: actually update 0 to 1 (#4756)
129934ad Small cleanup/refactoring in support of PR #5213 (#5251)
042c3cfd clang-tidy upgrade (to version 18) (#5272)
570d323b Add `while True` & `top` method to FAQ. (#5340)
a5fcc560 Enable type-safe interoperability between different independent Python/C++ bindings systems. (#5296)
Sam Gross (3):
3b47b464 fix: use manual padding of instance_map_shard (#5200)
8443d084 Use PyMutex instead of std::mutex in free-threaded build. (#5219)
f3a6d414 fix: make gil_safe_call_once thread-safe in free-threaded CPython (#5246)
StarQTius (1):
42455b5e fix: clear local internals after finalizing interpreter ornladios#2101 (ornladios#3744)
Stefano Rivera (1):
bdec5737 Use sysconfig in Python >= 3.10 (ornladios#3764)
Theodore Tsirpanis (1):
667563dd docs: remove outdated known limitation. (#5263)
Varun Agrawal (1):
3074608e fix(cmake): remove extra = in flto assignment (#5207)
Vasily Litvinov (1):
9e6a67d5 Properly translate C++ exception to Python exception when creating Python buffer from wrapped object (#5324)
Vemund Handeland (1):
1f187d9a Fix char8_t support (ornladios#4278)
Xiaofei Wang (1):
78e26321 Add `type_caster_std_function_specializations` feature. (ornladios#4597)
albanD (1):
da780a00 Make sure to properly untrack gc objects before freeing them (ornladios#4461)
cyy (1):
9d6a79c0 fix: issuses detected by static analyzer (ornladios#4440)
dependabot[bot] (9):
c06f324c chore(deps): bump ilammy/msvc-dev-cmd from 1.12.0 to 1.12.1 (ornladios#4493)
ec3f6e24 chore(deps): bump pypa/gh-action-pypi-publish from 1.6.4 to 1.8.1 (ornladios#4576)
ea10a69d chore(deps): bump actions/attest-build-provenance in the actions group (#5216)
4b2f7cd6 chore(deps): bump certifi from 2024.2.2 to 2024.7.4 in /docs (#5226)
d699e99c chore(deps): bump actions/attest-build-provenance in the actions group (#5243)
fe808a01 chore(deps): bump the actions group with 2 updates (#5287)
6ee574fa chore(deps): bump actions/attest-build-provenance in the actions group (#5297)
0a96ff7e chore(deps): bump actions/attest-build-provenance in the actions group (#5335)
54ab4249 chore(deps): bump the actions group with 2 updates (#5361)
fred-sch (1):
f9ae715d fix: typo in documentation (#5284)
kajananchinniah (1):
0ed64a04 docs: fixed typo in spelling of first (ornladios#4428)
pre-commit-ci[bot] (5):
d78de295 chore(deps): update pre-commit hooks (ornladios#4439)
3ea37d04 chore(deps): update pre-commit hooks (ornladios#4495)
41726b64 chore(deps): update pre-commit hooks (#5220)
44d0d9a4 chore(deps): update pre-commit hooks (#5288)
36ee4674 chore(deps): update pre-commit hooks (#5350)
pwdcd (1):
6685547e chore: remove repetitive words (#5308)
wenqing (1):
639ca6a7 Fixed a compilation error with gcc 14 (#5208)
xkszltl (1):
b596235f Inconsistent comments between 2 templates of `unchecked()`. (ornladios#4519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid that for older C-Blosc2 releases, with
ADIOS2_USE_Blosc2=ON, the search logic errors out after the config module was not found.Regression introduced in #3715 (after rebase).