Skip to content

Conversation

dtrudg
Copy link

@dtrudg dtrudg commented Jun 28, 2023

Handle registry.Service change from interface to struct.

I've seen #517 and #519 and am not clear why they were closed.

The old docker/docker dependency is blocking updating other dependencies in the containers ecosystem, where oras-go v1 is still in use. Would be grateful if the update could be applied to v1.

Handle registry.Service change from interface to struct.

Signed-off-by: David Trudgian <david.trudgian@sylabs.io>
@dtrudg dtrudg changed the title deps: update docker/docker to v24.0.2 deps: update docker/docker to v24.0.2 (v1) Jun 28, 2023
dtrudg added a commit to dtrudg/singularity that referenced this pull request Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for
docker/docker v24 is causing issues bumping other dependencies in
SingularityCE.

Switch temporarily to a sylabs fork with the update applied.

An upstream PR has been opened at:

oras-project/oras-go#527

If merged, we can revert to upstream.
dtrudg added a commit to dtrudg/singularity that referenced this pull request Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for
docker/docker v24 is causing issues bumping other dependencies in
SingularityCE.

Switch temporarily to a sylabs fork with the update applied.

An upstream PR has been opened at:

oras-project/oras-go#527

If merged, we can revert to upstream.
dtrudg added a commit to dtrudg/singularity that referenced this pull request Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for
docker/docker v24 is causing issues bumping other dependencies in
SingularityCE.

Switch temporarily to a sylabs fork with the update applied.

An upstream PR has been opened at:

oras-project/oras-go#527

If merged, we can revert to upstream.
dtrudg added a commit to dtrudg/singularity that referenced this pull request Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for
docker/docker v24 is causing issues bumping other dependencies in
SingularityCE.

Switch temporarily to a sylabs fork with the update applied.

An upstream PR has been opened at:

oras-project/oras-go#527

If merged, we can revert to upstream.
edytuk pushed a commit to vzokay/apptainer that referenced this pull request Jun 29, 2023
The lack of update in the v1 branch of oras.land/oras.go for
docker/docker v24 is causing issues bumping other dependencies in
SingularityCE.

Switch temporarily to a sylabs fork with the update applied.

An upstream PR has been opened at:

oras-project/oras-go#527

If merged, we can revert to upstream.

Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
@shizhMSFT shizhMSFT added the v1 Things belongs to version 1.x label Jun 30, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

Note: We should mention this in the release note of the next release. Although there is no API changes in our side, it may still break users if they are using the latest oras-go v1 along with old versions of docker/docker.

@shizhMSFT shizhMSFT merged commit d12e82e into oras-project:v1 Jun 30, 2023
andaaron added a commit to andaaron/zot that referenced this pull request Aug 31, 2023
Special note for oras.land/oras-go:
- 1.2.4 is not released yet, but tip of their v1 branch is compatible with docker v24.0.2
- 1.2.3 is not compatible with docker v24.0.2
Other 3rd party software depend on both oras-go v1 and docker v24

See also oras-project/oras-go#527

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron added a commit to project-zot/zot that referenced this pull request Aug 31, 2023
Special note for oras.land/oras-go:
- 1.2.4 is not released yet, but tip of their v1 branch is compatible with docker v24.0.2
- 1.2.3 is not compatible with docker v24.0.2
Other 3rd party software depend on both oras-go v1 and docker v24

See also oras-project/oras-go#527

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 15, 2023
4 tasks
mauriciovasquezbernal pushed a commit to inspektor-gadget/inspektor-gadget that referenced this pull request Sep 18, 2023
Bumps [oras.land/oras-go](https://github.com/oras-project/oras-go) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/oras-project/oras-go/releases)
- [Commits](oras-project/oras-go@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: oras.land/oras-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Remove replace directive to use docker > 0.23. See oras-project/oras-go#527.

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1 Things belongs to version 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants