-
Notifications
You must be signed in to change notification settings - Fork 102
deps: update docker/docker to v24.0.2 (v1) #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle registry.Service change from interface to struct. Signed-off-by: David Trudgian <david.trudgian@sylabs.io>
dtrudg
added a commit
to dtrudg/singularity
that referenced
this pull request
Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for docker/docker v24 is causing issues bumping other dependencies in SingularityCE. Switch temporarily to a sylabs fork with the update applied. An upstream PR has been opened at: oras-project/oras-go#527 If merged, we can revert to upstream.
dtrudg
added a commit
to dtrudg/singularity
that referenced
this pull request
Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for docker/docker v24 is causing issues bumping other dependencies in SingularityCE. Switch temporarily to a sylabs fork with the update applied. An upstream PR has been opened at: oras-project/oras-go#527 If merged, we can revert to upstream.
dtrudg
added a commit
to dtrudg/singularity
that referenced
this pull request
Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for docker/docker v24 is causing issues bumping other dependencies in SingularityCE. Switch temporarily to a sylabs fork with the update applied. An upstream PR has been opened at: oras-project/oras-go#527 If merged, we can revert to upstream.
dtrudg
added a commit
to dtrudg/singularity
that referenced
this pull request
Jun 28, 2023
The lack of update in the v1 branch of oras.land/oras.go for docker/docker v24 is causing issues bumping other dependencies in SingularityCE. Switch temporarily to a sylabs fork with the update applied. An upstream PR has been opened at: oras-project/oras-go#527 If merged, we can revert to upstream.
edytuk
pushed a commit
to vzokay/apptainer
that referenced
this pull request
Jun 29, 2023
The lack of update in the v1 branch of oras.land/oras.go for docker/docker v24 is causing issues bumping other dependencies in SingularityCE. Switch temporarily to a sylabs fork with the update applied. An upstream PR has been opened at: oras-project/oras-go#527 If merged, we can revert to upstream. Signed-off-by: Edita Kizinevic <edita.kizinevic@cern.ch>
This was referenced Jun 29, 2023
shizhMSFT
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: We should mention this in the release note of the next release. Although there is no API changes in our side, it may still break users if they are using the latest |
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Aug 31, 2023
Special note for oras.land/oras-go: - 1.2.4 is not released yet, but tip of their v1 branch is compatible with docker v24.0.2 - 1.2.3 is not compatible with docker v24.0.2 Other 3rd party software depend on both oras-go v1 and docker v24 See also oras-project/oras-go#527 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron
added a commit
to project-zot/zot
that referenced
this pull request
Aug 31, 2023
Special note for oras.land/oras-go: - 1.2.4 is not released yet, but tip of their v1 branch is compatible with docker v24.0.2 - 1.2.3 is not compatible with docker v24.0.2 Other 3rd party software depend on both oras-go v1 and docker v24 See also oras-project/oras-go#527 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
mauriciovasquezbernal
pushed a commit
to inspektor-gadget/inspektor-gadget
that referenced
this pull request
Sep 18, 2023
Bumps [oras.land/oras-go](https://github.com/oras-project/oras-go) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/oras-project/oras-go/releases) - [Commits](oras-project/oras-go@v1.2.3...v1.2.4) --- updated-dependencies: - dependency-name: oras.land/oras-go dependency-type: direct:production update-type: version-update:semver-patch ... Remove replace directive to use docker > 0.23. See oras-project/oras-go#527. Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
registry.Service
change from interface to struct.I've seen #517 and #519 and am not clear why they were closed.
The old docker/docker dependency is blocking updating other dependencies in the containers ecosystem, where oras-go v1 is still in use. Would be grateful if the update could be applied to v1.