This repository was archived by the owner on Jul 11, 2023. It is now read-only.
fix(): remove support for incompatible tls versions for envoy TLSMaxProtocolVersion #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## release-v1.2 #5298 +/- ##
================================================
- Coverage 68.83% 68.81% -0.02%
================================================
Files 210 210
Lines 15679 15679
================================================
- Hits 10792 10789 -3
- Misses 4836 4839 +3
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
keithmattix
suggested changes
Mar 22, 2023
keithmattix
reviewed
Mar 27, 2023
246058a to
286063f
Compare
keithmattix
suggested changes
Mar 27, 2023
7a465bd to
c2d863d
Compare
keithmattix
previously approved these changes
Mar 28, 2023
jaellio
reviewed
Mar 29, 2023
d020e66 to
2f8edde
Compare
jaellio
previously approved these changes
Mar 30, 2023
keithmattix
previously approved these changes
Mar 30, 2023
c3f6032
c3f6032 to
51289fd
Compare
…rotocolVersion Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
51289fd to
e57e7d2
Compare
keithmattix
approved these changes
Mar 30, 2023
jaellio
approved these changes
Mar 30, 2023
|
@whitneygriffith don't forget to submit a similar PR for the main branch |
jaellio
pushed a commit
to jaellio/osm
that referenced
this pull request
Apr 5, 2023
…rotocolVersion (openservicemesh#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
jaellio
pushed a commit
to jaellio/osm
that referenced
this pull request
Apr 5, 2023
…rotocolVersion (openservicemesh#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com> Signed-off-by: jaellio <jaellio@microsoft.com>
jaellio
pushed a commit
to jaellio/osm
that referenced
this pull request
Apr 7, 2023
…rotocolVersion (openservicemesh#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com> Signed-off-by: jaellio <jaellio@microsoft.com>
jaellio
pushed a commit
to jaellio/osm
that referenced
this pull request
Apr 7, 2023
…rotocolVersion (openservicemesh#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com> Signed-off-by: jaellio <jaellio@microsoft.com>
jaellio
pushed a commit
to jaellio/osm
that referenced
this pull request
Apr 11, 2023
…rotocolVersion (openservicemesh#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com> Signed-off-by: jaellio <jaellio@microsoft.com>
jaellio
pushed a commit
that referenced
this pull request
Apr 11, 2023
…rotocolVersion (#5298) Removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com> Signed-off-by: jaellio <jaellio@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Part of #5282. This removes support for TLSv1_0 and TLSv1_1 from the envoy TLSMaxProtocolVersion options.
Testing done:
Affected area: