This repository was archived by the owner on Jul 11, 2023. It is now read-only.
cert changes: Fix GetTrustedCAs; align import names; use component logger #4870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
54affd7 to
36dd5a1
Compare
nojnhuh
approved these changes
Jul 1, 2022
draychev
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
@steeling thank you for chopping up the large PR into smaller changes.
This looks great.
Would you be so kind to change the PR title/subject in a way that describes the changes?
I worry that when we merge the commit will say small cert related changes. #4870 and that's not very informative.
jaellio
approved these changes
Jul 1, 2022
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 1, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 1, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 19, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 19, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 19, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 20, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 21, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
steeling
added a commit
to steeling/osm
that referenced
this pull request
Jul 21, 2022
1. align imports on casing for tresorFake 2. use GetTrustedCAs where appropriate 3. use a logger component in certificate package Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix flaky test Signed-off-by: Sean Teeling <seanteeling@microsoft.com> address comments Signed-off-by: Sean Teeling <seanteeling@microsoft.com> fix rebase copy/pasta Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teeling seanteeling@microsoft.com