This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Add root path to ingress in ingress_backend_e2e #4756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojnhuh
approved these changes
May 24, 2022
shashankram
reviewed
May 24, 2022
78add0b to
5d69245
Compare
Signed-off-by: nshankar13 <nshankar@microsoft.com>
shashankram
approved these changes
May 25, 2022
nshankar13
added a commit
to nshankar13/osm
that referenced
this pull request
May 25, 2022
Addresses an issue where an ingress without a root path does not work for some non-kind distributions like AKS: kubernetes/ingress-nginx#8518. Adding a wildcard path in addition to the status/200 path resolves the issue. Signed-off-by: nshankar13 <nshankar@microsoft.com>
jaellio
pushed a commit
that referenced
this pull request
May 26, 2022
Addresses an issue where an ingress without a root path does not work for some non-kind distributions like AKS: kubernetes/ingress-nginx#8518. Adding a wildcard path in addition to the status/200 path resolves the issue. Signed-off-by: nshankar13 <nshankar@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nshankar13 nshankar@microsoft.com
Description: This PR addresses an issue where an ingress without a root path does not work for some non-kind distributions like AKS: kubernetes/ingress-nginx#8518. Adding a wildcard path in addition to the status/200 path resolved the issue.
The ingress error happens intermittently.
Testing done: Tested locally on AKS cluster.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?