This repository was archived by the owner on Jul 11, 2023. It is now read-only.
pkg/injector: Enable podIP proxying via meshconfig setting #4701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openservicemesh#4653. Allows customers to choose how their traffic gets proxied Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4701 +/- ##
==========================================
- Coverage 69.48% 69.47% -0.02%
==========================================
Files 217 217
Lines 15495 15524 +29
==========================================
+ Hits 10767 10785 +18
- Misses 4678 4689 +11
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
f2641c1 to
04d36c0
Compare
shashankram
suggested changes
Apr 28, 2022
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
30e4b0a to
2de59eb
Compare
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
82fe4d4 to
c334d83
Compare
shashankram
approved these changes
Apr 28, 2022
Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
nojnhuh
approved these changes
Apr 28, 2022
keithmattix
added a commit
to keithmattix/osm
that referenced
this pull request
May 3, 2022
…cemesh#4701) * pkg/injector: Enable podIP proxying via meshconfig setting Fixes openservicemesh#4653. Allows customers to choose how their traffic gets proxied Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Fix linting and test errors Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Inject pod_ip into initcontainer Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Fix port in pod command Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Reduce leaky abstraction by not passing configurator to generateIPTables Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Use iptables -I to make the rules dynamic Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> * Fix array append Signed-off-by: Keith Mattix II <keithmattix2@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4653. Allows customers to choose how their traffic gets proxied
Signed-off-by: Keith Mattix II keithmattix2@gmail.com
Description:
Testing done:
Unit and E2E tests
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? yes