This repository was archived by the owner on Jul 11, 2023. It is now read-only.
bump the version of the k8s go client and generated code #4680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1f12c1 to
8d44395
Compare
shashankram
approved these changes
Apr 21, 2022
|
Needs to be rebased. |
1c41dcf to
2cfae97
Compare
Codecov Report
@@ Coverage Diff @@
## main #4680 +/- ##
=======================================
Coverage 69.75% 69.75%
=======================================
Files 217 217
Lines 15233 15233
=======================================
Hits 10626 10626
Misses 4557 4557
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
nojnhuh
reviewed
Apr 22, 2022
There was a problem hiding this comment.
I can think of one more spot to update:
osm/dockerfiles/Dockerfile.osm-crds
Line 5 in 2cfae97
2cfae97 to
0103a6f
Compare
nojnhuh
reviewed
Apr 22, 2022
dockerfiles/Dockerfile.osm-crds
Outdated
| @@ -2,7 +2,7 @@ FROM --platform=$BUILDPLATFORM busybox:1.33 AS builder | |||
| ARG TARGETPLATFORM | |||
| # Talking to the internet in an arm64 container doesn't seem to work from a | |||
| # amd64 Mac, so download the kubectl binary in a stage running the native arch. | |||
| RUN wget https://dl.k8s.io/release/v1.22.2/bin/$TARGETPLATFORM/kubectl -O /bin/kubectl && \ | |||
| RUN wget https://dl.k8s.io/release/v1.23.5/bin/linux/amd64/kubectl -O /bin/kubectl && \ | |||
There was a problem hiding this comment.
This still needs $TARGETPLATFORM so arm64 builds work.
There was a problem hiding this comment.
oops, bad copy/pasta
Upgrades MeshConfig to v1alpha3 with new `spec.sidecar.localProxyMode` field for user to control how mesh traffic gets proxied. Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
0103a6f to
9ece6f0
Compare
nojnhuh
approved these changes
Apr 22, 2022
keithmattix
added a commit
to keithmattix/osm
that referenced
this pull request
May 3, 2022
…penservicemesh#4680) Upgrades MeshConfig to v1alpha3 with new `spec.sidecar.localProxyMode` field for user to control how mesh traffic gets proxied. Signed-off-by: Keith Mattix II <keithmattix2@gmail.com> Signed-off-by: Sean Teeling <seanteeling@microsoft.com> Co-authored-by: Keith Mattix II <keithmattix2@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the version In prep for #4673