Remove `assertTrue(true)` and `assertFalse(false)` #767

aet2505 · 2025-07-13T19:36:41Z

What's changed?

Enhance existing recipe to convert assertTrue(false, <message>) to fail(<message>) to handle the no message overload
Add new recipe to remove cases such as assertTrue(true)
Add new recipe to Junit5BestPractices recipe list

What's your motivation?

Resolve Issue Avoid assertTrue() or assertFalse() with constant boolean arguments #762

Anything in particular you'd like reviewers to focus on?

In the new recipe any message passed to the assert will be lost.
While this message will never be fired, it potentially is used as a pseudo comment? Not sure what the best pattern here is.

Have you considered any alternatives or workarounds?

I considered keeping these as refaster recipes but that would lead to a change in recipe name for the enhancement. Maintaining the recipe name felt beneficial.
Again due to maintaining the recipe name I chose to add the second case as a new recipe. While this could be merged it did not feel like behaviour that would be expected under the existing name

Checklist

I've added unit tests to cover both positive and negative cases
I've read and applied the recipe conventions and best practices
I've used the IntelliJ IDEA auto-formatter on affected files

…e calls The existing refaster recipe only handled the method signature where a method is passed. Add additional case for no message passed to the assert Converted from Refaster recipe to maintain existing recipe name.

…al value is passed This case is a no-op and the assertion can never fail, for improved readability this can be removed Additionally add to JUnit5BestPractices recipe.

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToFailRecipe.java

Co-authored-by: Tim te Beek <timtebeek@gmail.com>

src/test/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanRemovedTest.java

timtebeek

Thanks for the help here @aet2505 ! I've made some changes to the Refaster annotation processor such that we can still use Refaster here, as it's that much more convenient that I didn't want to have to maintain imperative recipes. We'll merge this once there's a new release of rewrite-templating tomorrow to apply the last code suggestion here.

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanRemoved.java

aet2505 · 2025-07-23T08:23:17Z

Thanks for the help here @aet2505 ! I've made some changes to the Refaster annotation processor such that we can still use Refaster here, as it's that much more convenient that I didn't want to have to maintain imperative recipes. We'll merge this once there's a new release of rewrite-templating tomorrow to apply the last code suggestion here.

Amazing thank you for getting this over the finish line!

…alBooleanRemovedTest.java

…rom 3.11.0 to 3.15.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks) from 3.11.0 to 3.15.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-testing-frameworks's releases](https://github.com/openrewrite/rewrite-testing-frameworks/releases).* > 3.15.0 > ------ > > What's Changed > -------------- > > * Include additional AssertJ migrations by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#773](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/773) > * Include recipes in larger composites where possible by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#774](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/774) > * Retain comments when chaining assertions by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#775](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/775) > * refactor: Static imports for Collections and Collectors by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#779](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/779) > * Added implementation to extract any expression arguments from last statement in assertThrows by [`@JohannisK`](https://github.com/JohannisK) in [openrewrite/rewrite-testing-frameworks#724](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/724) > * Don't clean up mockito imports for Kotlin by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-testing-frameworks#782](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/782) > * Adding dependency guards to the Junit 4 -> 5 migration for when the POM or build.gradle have a dependency on `org.testng:testng`. by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#760](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/760) > * rename settings.local.json to settings.json by [`@zieka`](https://github.com/zieka) in [openrewrite/rewrite-testing-frameworks#783](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/783) > * Fix ClassCastException in PowerMockitoWhenNewToMockito by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#786](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/786) > * MockitoJUnitRunnerToExtension: Handle existing MockitoExtension by [`@amishra-u`](https://github.com/amishra-u) in [openrewrite/rewrite-testing-frameworks#788](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/788) > > **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.14.0...v3.15.0> > > 3.14.1 > ------ > > What's Changed > -------------- > > * OpenRewrite v8.59.1: <https://github.com/openrewrite/rewrite> > > **Full Changelog**: <https://github.com/openrewrite/rewrite-testing-frameworks> > > 3.14.0 > ------ > > What's Changed > -------------- > > * Collapse more consecutive assertions by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#769](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/769) > * refactor: Unwrap else block after return or throw statement by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#771](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/771) > * Remove all PowerMock imports after migration by [`@JohannisK`](https://github.com/JohannisK) in [openrewrite/rewrite-testing-frameworks#770](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/770) > * Remove `assertTrue(true)` and `assertFalse(false)` by [`@aet2505`](https://github.com/aet2505) in [openrewrite/rewrite-testing-frameworks#767](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/767) > > New Contributors > ---------------- > > * [`@aet2505`](https://github.com/aet2505) made their first contribution in [openrewrite/rewrite-testing-frameworks#767](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/767) > > **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.13.0...v3.14.0> > > 3.13.0 > ------ > > What's Changed > -------------- > > * Removing `NoInitializationForInjectMock` recipe due to side effects when using recipe by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#765](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/765) > * Adding functionality to `MockitoWhenOnStaticToMockStatic` for recognizing an existing try-with-resources `MockedStatic<T>` can be reused instead of creating a new one. by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#766](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/766) > * Inconvertible Mockito `when` situation involving lambda and static method. by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#763](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/763) > * Changing order of `mockito-all` -> `mockito-core` change vs `org.mockito:*` upgrade, and made the former upgrade to `3.x` at the same time, as there aren't aligned versions between the two. by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#768](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/768) > > New Contributors > ---------------- > > * [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) made their first contribution in [openrewrite/rewrite-testing-frameworks#765](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/765) > > **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.12.0...v3.13.0> > > 3.12.0 > ------ > > What's Changed > -------------- > > * Fix for JUnit test method throws clause preservation by [`@knutwannheden`](https://github.com/knutwannheden) in [openrewrite/rewrite-testing-frameworks#755](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/755) > * refactor: org.openrewrite.mavencentral by [`@Laurens-W`](https://github.com/Laurens-W) in [openrewrite/rewrite-testing-frameworks#756](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/756) ... (truncated) Commits * [`76c6888`](openrewrite/rewrite-testing-frameworks@76c6888) MockitoJUnitRunnerToExtension: Handle existing MockitoExtension ([#788](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/788)) * [`75d2019`](openrewrite/rewrite-testing-frameworks@75d2019) Retain `Throwable` in `SimplifyTestThrows` * [`0ea47e9`](openrewrite/rewrite-testing-frameworks@0ea47e9) Include `SimplifyTestThrows` with `JUnit5BestPractices` * [`efb0a4e`](openrewrite/rewrite-testing-frameworks@efb0a4e) Add AssertJ change type recipes for classes deprecated in v3.27.4 * [`f203a20`](openrewrite/rewrite-testing-frameworks@f203a20) Update documentation examples * [`69d7716`](openrewrite/rewrite-testing-frameworks@69d7716) Fix ClassCastException in PowerMockitoWhenNewToMockito ([#786](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/786)) * [`dc6f272`](openrewrite/rewrite-testing-frameworks@dc6f272) rename settings.local.json to settings.json ([#783](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/783)) * [`96fca52`](openrewrite/rewrite-testing-frameworks@96fca52) Documentation example for MockitoJUnitRunnerToExtensionTest * [`9a2082a`](openrewrite/rewrite-testing-frameworks@9a2082a) Adding dependency guards to the Junit 4 -> 5 migration for when the POM or bu... * [`74366cf`](openrewrite/rewrite-testing-frameworks@74366cf) OpenRewrite recipe best practices * Additional commits viewable in [compare view](openrewrite/rewrite-testing-frameworks@v3.11.0...v3.15.0) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-testing-frameworks&package-manager=maven&previous-version=3.11.0&new-version=3.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

aet2505 added 2 commits July 13, 2025 20:28

Add recipe to remove calls to assertTrue or assertFalse where a liter…

6b17682

…al value is passed This case is a no-op and the assertion can never fail, for improved readability this can be removed Additionally add to JUnit5BestPractices recipe.

moderne-meeseeks bot added this to OpenRewrite Jul 13, 2025

github-project-automation bot moved this to In Progress in OpenRewrite Jul 13, 2025

github-actions bot reviewed Jul 16, 2025

View reviewed changes

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java Outdated Show resolved Hide resolved

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java Outdated Show resolved Hide resolved

timtebeek self-requested a review July 16, 2025 14:27

Apply suggestions from bot code review

8d89ccd

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

timtebeek reviewed Jul 17, 2025

View reviewed changes

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java Outdated Show resolved Hide resolved

timtebeek reviewed Jul 17, 2025

View reviewed changes

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToNoOpRecipe.java Outdated Show resolved Hide resolved

timtebeek reviewed Jul 17, 2025

View reviewed changes

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanToFailRecipe.java Outdated Show resolved Hide resolved

timtebeek assigned aet2505 Jul 18, 2025

Remove unused code

c1a80ac

Co-authored-by: Tim te Beek <timtebeek@gmail.com>

aet2505 force-pushed the recipe/assert-literal-boolean branch from 3d8dd6a to c1a80ac Compare July 21, 2025 18:00

Update static imports test to use specific recipe not full best practice

6153f11

aet2505 requested a review from timtebeek July 22, 2025 18:39

timtebeek added 3 commits July 22, 2025 23:27

Use Refaster

0aa63f0

Restore original test name

076a278

Fix tests for now

3a619ec

timtebeek reviewed Jul 22, 2025

View reviewed changes

src/test/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanRemovedTest.java Outdated Show resolved Hide resolved

Update references

07bcacc

timtebeek changed the title ~~Avoid assertTrue() or assertFalse() with constant boolean arguments~~ Remove assertTrue(true) and assertFalse(false) Jul 22, 2025

timtebeek approved these changes Jul 22, 2025

View reviewed changes

github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Jul 22, 2025

github-actions bot reviewed Jul 22, 2025

View reviewed changes

src/main/java/org/openrewrite/java/testing/cleanup/AssertLiteralBooleanRemoved.java Outdated Show resolved Hide resolved

timtebeek added 2 commits July 22, 2025 23:53

Apply formatter on imports

fd9852f

Merge branch 'main' into recipe/assert-literal-boolean

516dc26

timtebeek self-requested a review July 22, 2025 21:53

timtebeek and others added 2 commits July 23, 2025 12:47

Update src/test/java/org/openrewrite/java/testing/cleanup/AssertLiter…

679b05a

…alBooleanRemovedTest.java

Separate the test cases to fix imports

8f11008

timtebeek merged commit 29a8273 into openrewrite:main Jul 23, 2025
2 checks passed

github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 23, 2025

timtebeek mentioned this pull request Jul 23, 2025

Avoid assertTrue() or assertFalse() with constant boolean arguments #762

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `assertTrue(true)` and `assertFalse(false)` #767

Remove `assertTrue(true)` and `assertFalse(false)` #767

Uh oh!

aet2505 commented Jul 13, 2025 •

edited by timtebeek

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timtebeek left a comment

Uh oh!

Uh oh!

aet2505 commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Remove assertTrue(true) and assertFalse(false) #767

Remove assertTrue(true) and assertFalse(false) #767

Uh oh!

Conversation

aet2505 commented Jul 13, 2025 • edited by timtebeek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Have you considered any alternatives or workarounds?

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timtebeek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aet2505 commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Remove `assertTrue(true)` and `assertFalse(false)` #767

Remove `assertTrue(true)` and `assertFalse(false)` #767

aet2505 commented Jul 13, 2025 •

edited by timtebeek

Loading