Update syscall to start loong64 support #3765

zhaixiaojuan · 2023-03-09T06:28:42Z

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html

AkihiroSuda · 2023-03-09T06:56:41Z

libcontainer/system/syscall_linux_64.go

 // +build linux
-// +build arm64 amd64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x
+// +build arm64 amd64 loong64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x



seccomp needs to be updated too

runc/libcontainer/seccomp/config.go

Line 74 in a2f27f0

"SCMP_ARCH_RISCV64": "riscv64",

runc/libcontainer/seccomp/patchbpf/enosys_linux.go

Line 82 in a2f27f0

const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64;

...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)

...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)

Sorry, I didn't know that you had submitted a PR before submitting the PR (seccomp/libseccomp-golang#107), but there are some differences in the submitted code, please review

seccomp needs to be updated too

runc/libcontainer/seccomp/config.go

Line 74 in a2f27f0

"SCMP_ARCH_RISCV64": "riscv64",

runc/libcontainer/seccomp/patchbpf/enosys_linux.go

Line 82 in a2f27f0

const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64;

I have updated it, please check

kolyshkin · 2023-03-10T22:14:36Z

Let's wait until runc dependencies have loong64 supported. That includes:

golang (I think it is supported already)
x/sys/unix
libseccomp (not in a released version)
libseccomp-golang
what else?

Once all that is ready and released, we can add the support. Doing it earlier doesn't make much practical sense.

zhaixiaojuan · 2023-12-15T09:46:59Z

@kolyshkin
Hi kolyshkin, Could you consider merging this PR(seccomp/libseccomp-golang#106) ?

runc does not support loongarch64 yet. opencontainers/runc#3765

zhaixiaojuan · 2025-01-13T09:16:55Z

Let's wait until runc dependencies have loong64 supported. That includes:

golang (I think it is supported already)

x/sys/unix

libseccomp (not in a released version)

libseccomp-golang

what else?

Once all that is ready and released, we can add the support. Doing it earlier doesn't make much practical sense.
@kolyshkin
Currently, all these dependencies have been met. I have reorganized the patch according to the latest code. Could you merge this PR?

libcontainer/seccomp/config.go

libcontainer/seccomp/patchbpf/enosys_linux_test.go

kolyshkin · 2025-02-09T20:59:07Z

Let's wait until runc dependencies have loong64 supported. That includes:

golang (I think it is supported already)

x/sys/unix

libseccomp (not in a released version)

libseccomp-golang

what else?

Once all that is ready and released, we can add the support. Doing it earlier doesn't make much practical sense.

@kolyshkin
Currently, all these dependencies have been met. I have reorganized the patch according to the latest code. Could you merge this PR?

From the list above, libseccomp was just released last month, and I'm working on libseccomp-golang right now (see seccomp/libseccomp-golang#117). Once libseccomp-golang is released, we can get this out of draft. For now, you can help reviewing commits in there.

kolyshkin · 2025-04-23T21:02:09Z

libseccomp-golang v0.11.0 is out! @zhaixiaojuan PTAL

zhaixiaojuan · 2025-04-25T07:04:42Z

@AkihiroSuda @kolyshkin
Hi, Currently, all the dependencies are met. Can this PR be reopened and considered for merging?

AkihiroSuda · 2025-04-25T15:13:22Z

Needs rebase, LGTM after that

zhaixiaojuan · 2025-04-27T03:41:44Z

@kolyshkin @AkihiroSuda
Hi, I checked the errors in running tests in current ci:

=== RUN   TestEnosysStub_MultiArch
    enosys_linux_test.go:171: unknown libseccomp architecture "loong64": cannot convert unrecognized string "loong64"
--- FAIL: TestEnosysStub_MultiArch (0.00s)

This error is the same as seccomp/libseccomp-golang#112 need to add loong64 in the case statement of the libseccomp-golang/seccomp.go file:

func GetArchFromString(arch string) (ScmpArch, error) {
	if err := ensureSupportedVersion(); err != nil {
		return ArchInvalid, err
	}

	switch strings.ToLower(arch) {
	case "x86":
		return ArchX86, nil
	case "amd64", "x86-64", "x86_64", "x64":
		return ArchAMD64, nil
        ......
    -   case “loongarch64”:
    +   case "loong64", "loongarch64":

In addition, the relevant patches for this problem have been merged into the Debian community in advance.Detailed patch link address: https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=1095322;filename=golang-github-seccomp-libseccomp-golang-add-loongarch64-support.patch;msg=5

zhaixiaojuan · 2025-05-12T03:33:43Z

@kolyshkin
Hi, Is there any progress on this issue? Can this patch(seccomp/libseccomp-golang#112) be considered for merging?

=== RUN   TestEnosysStub_MultiArch
    enosys_linux_test.go:171: unknown libseccomp architecture "loong64": cannot convert unrecognized string "loong64"
--- FAIL: TestEnosysStub_MultiArch (0.00s)

kolyshkin · 2025-08-05T20:23:20Z

@zhaixiaojuan I've released https://github.com/seccomp/libseccomp-golang/releases/tag/v0.11.1 so this can be updated now.

kolyshkin · 2025-08-06T04:53:45Z

@zhaixiaojuan I've released https://github.com/seccomp/libseccomp-golang/releases/tag/v0.11.1 so this can be updated now.

And the bump PR (#4839) is now merged

Signed-off-by: zhaixiaojuan <67671683+zhaixiaojuan@users.noreply.github.com>

zhaixiaojuan · 2025-08-07T03:03:07Z

@zhaixiaojuan I've released https://github.com/seccomp/libseccomp-golang/releases/tag/v0.11.1 so this can be updated now.

And the bump PR (#4839) is now merged

@kolyshkin Thank you very much, I will rebase this PR

zhaixiaojuan · 2025-08-11T07:07:54Z

@AkihiroSuda
Hi, I checked the latest error message:

=== RUN TestEnosysStub_SingleArch/arch=x86/action=log [2040](https://github.com/opencontainers/runc/pull/3765#step:15:2041) enosys_linux_test.go:190: unknown syscall "setns" on arch "loong64": architecture loong64 is not supported on this version of the library [2041](https://github.com/opencontainers/runc/pull/3765#step:15:2042)

=== RUN TestEnosysStub_SingleArch/arch=x86/action=errno [2042](https://github.com/opencontainers/runc/pull/3765#step:15:2043) enosys_linux_test.go:190: unknown syscall "setns" on arch "loong64": architecture loong64 is not supported on this version of the library

I've confirmed that this error is caused by the libseccomp used in the test environment not supporting the loongarch64 architecture. Currently, support for loongarch64 is available at http://ftp.ports.debian.org/debian-ports/pool-loong64/main/libs/libseccomp/ .

zhaixiaojuan · 2025-08-21T03:45:03Z

=== RUN TestEnosysStub_SingleArch/arch=x86/action=log [2040](https://github.com/opencontainers/runc/pull/3765#step:15:2041) enosys_linux_test.go:190: unknown syscall "setns" on arch "loong64": architecture loong64 is not supported on this version of the library [2041](https://github.com/opencontainers/runc/pull/3765#step:15:2042)

=== RUN TestEnosysStub_SingleArch/arch=x86/action=errno [2042](https://github.com/opencontainers/runc/pull/3765#step:15:2043) enosys_linux_test.go:190: unknown syscall "setns" on arch "loong64": architecture loong64 is not supported on this version of the library

I've confirmed that this error is caused by the libseccomp used in the test environment not supporting the loongarch64 architecture. Currently, support for loongarch64 is available at http://ftp.ports.debian.org/debian-ports/pool-loong64/main/libs/libseccomp/ .

@AkihiroSuda
Hi, could we provide a loongarch64 environment to resolve the above issues?
I'm also very eager to hear your other suggestions. We'll fully support and meet your needs, whether in software or hardware.

AkihiroSuda reviewed Mar 9, 2023

View reviewed changes

zhaixiaojuan force-pushed the main branch 2 times, most recently from 96783d9 to 7930666 Compare March 10, 2023 09:41

kolyshkin marked this pull request as draft March 10, 2023 22:12

zhaixiaojuan force-pushed the main branch from 7930666 to 50cacf3 Compare May 17, 2023 08:11

AkihiroSuda mentioned this pull request Sep 26, 2023

Add loong64 support containerd/nerdctl#2533

Merged

kolyshkin mentioned this pull request Oct 3, 2023

libcontainer: Add support for loong64 #4044

Closed

algitbot pushed a commit to alpinelinux/aports that referenced this pull request May 8, 2024

community/ctop: disable on loongarch64

fa25d9d

runc does not support loongarch64 yet. opencontainers/runc#3765

utam0k mentioned this pull request May 29, 2024

Add dependencies that support the loongarch64 architecture youki-dev/youki#2799

Open

zhaixiaojuan force-pushed the main branch from 50cacf3 to 68f5c79 Compare January 13, 2025 09:09

kolyshkin reviewed Feb 9, 2025

View reviewed changes

libcontainer/seccomp/config.go Show resolved Hide resolved

kolyshkin reviewed Feb 9, 2025

View reviewed changes

libcontainer/seccomp/patchbpf/enosys_linux_test.go Show resolved Hide resolved

Add loong64 support

d426589

zhaixiaojuan force-pushed the main branch from 68f5c79 to d426589 Compare April 27, 2025 02:25

This was referenced Aug 5, 2025

libct/seccomp: add loong64 to KnownArchs #4816

Closed

build: add loogarch in makefile #4826

Closed

Merge branch 'main' into main

5f1ea96

Signed-off-by: zhaixiaojuan <67671683+zhaixiaojuan@users.noreply.github.com>

Merge branch 'main' into main

18a5aaa

Update syscall to start loong64 support #3765

Are you sure you want to change the base?

Update syscall to start loong64 support #3765

Uh oh!

Conversation

zhaixiaojuan commented Mar 9, 2023

Uh oh!

AkihiroSuda Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

kolyshkin Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

zhaixiaojuan Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

zhaixiaojuan Mar 10, 2023

Choose a reason for hiding this comment

Uh oh!

kolyshkin commented Mar 10, 2023

Uh oh!

zhaixiaojuan commented Dec 15, 2023

Uh oh!

zhaixiaojuan commented Jan 13, 2025

Uh oh!

Uh oh!

Uh oh!

kolyshkin commented Feb 9, 2025

Uh oh!

kolyshkin commented Apr 23, 2025

Uh oh!

zhaixiaojuan commented Apr 25, 2025

Uh oh!

AkihiroSuda commented Apr 25, 2025

Uh oh!

zhaixiaojuan commented Apr 27, 2025

Uh oh!

zhaixiaojuan commented May 12, 2025

Uh oh!

kolyshkin commented Aug 5, 2025

Uh oh!

kolyshkin commented Aug 6, 2025

Uh oh!

zhaixiaojuan commented Aug 7, 2025

Uh oh!

zhaixiaojuan commented Aug 11, 2025

Uh oh!

zhaixiaojuan commented Aug 21, 2025

Uh oh!

Uh oh!