Fix the import of Tkinter in Python 3+ #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A patch that fixes this without using six would be great.
…On Fri, 3 Apr 2020, 19:07 Maksim Rakitin, ***@***.***> wrote:
While following the example at
https://open-babel.readthedocs.io/en/latest/UseTheLibrary/PythonInstall.html#test-the-installation,
noticed that the mol.draw() step fails on importing of Tkinter in Python
3.7. The module was renamed to tkinter in Python 3+ versions, and the six
library supports the proper handling of the change:
https://six.readthedocs.io/#module-six.moves. I added six as the install
requirement.
------------------------------
You can view, comment on, or merge this pull request online at:
#2157
Commit Summary
- Fix the import of Tkinter in Python 3+
File Changes
- *M* scripts/python/openbabel/pybel.py
<https://github.com/openbabel/openbabel/pull/2157/files#diff-863e0301a7472d65e3d8a16069b84301>
(2)
- *M* scripts/python/setup.py
<https://github.com/openbabel/openbabel/pull/2157/files#diff-4e89b66ccedac44670411667ec0b727d>
(1)
Patch Links:
- https://github.com/openbabel/openbabel/pull/2157.patch
- https://github.com/openbabel/openbabel/pull/2157.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2157>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCGKKOEUDARWBSS5GEUDRKYQV7ANCNFSM4L4LAHWQ>
.
|
|
Why is six a problem? It properly takes care of the py2->py3 transition, is available for all platforms on PyPI and conda. |
|
Nothing wrong with six, per se. We avoid adding dependencies unless
necessary.
…On Sun, 5 Apr 2020, 12:15 Maksim Rakitin, ***@***.***> wrote:
Why is six a problem? It properly takes care of the py2->py3 transition,
is available for all platforms on PyPI and conda.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2157 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCGNKEZRXKSMNTC6HR2LRLBR3ZANCNFSM4L4LAHWQ>
.
|
|
@baoilleach, please check the fix. |
|
Thanks Maksim. Looks great. |
|
You are welcome, Noel! Thanks for accepting the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While following the example at https://open-babel.readthedocs.io/en/latest/UseTheLibrary/PythonInstall.html#test-the-installation, noticed that the
mol.draw()step fails on importing ofTkinterin Python 3.7. The module was renamed totkinterin Python 3+ versions, and thesixlibrary supports the proper handling of the change: https://six.readthedocs.io/#module-six.moves (thanks to @tacaswell for the reference). I addedsixas the install requirement.