This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Instance write buffer metrics #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following api calls * /api/instance-buffered-write-metrics-raw/:seconds * /api/instance-buffered-write-metrics-aggregated/:seconds
* also change collection name strings to constants
|
I'm upgrading the go-metrics in this, PR but it's just because my code only works on the latest version of the library, I can move this upgrade to another PR if it the changes are good |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #113
Description
This is the rebased version of #146, it:
Adds fixed collection names to avoid errors when creating new ones
Adds a write-buffer collection to store individual write-buffer counters to be either aggregated or exposed in raw format
Adds endpoints to
metrics/instance-write-buffer/{raw,aggregated}/:secondsUpdates go-metrics to the latest commit (3113b8401b8a98917cde58f8bbd42a1b1c03b1fd)
contributed code is using same conventions as original code
code is formatted via
gofmt(please avoidgoimports)code is built via
./build.shcode is tested via
go test ./go/...