This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Add API calls to provide write buffer metrics (2nd attempt) #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following api calls * /api/instance-buffered-write-metrics-raw/:seconds * /api/instance-buffered-write-metrics-aggregated/:seconds
* also change collection name strings to constants
shlomi-noach
approved these changes
Apr 9, 2017
| } | ||
|
|
||
| return wba | ||
| } |
There was a problem hiding this comment.
I'm pretty sure go-metrics, which we used under vendor, automatically does the 50th, 75th etc. percentiles. Can you not use that?
There was a problem hiding this comment.
It doesn't work on non-integer values. I guess I could ensure I'm using the time.Duration values and work on that and then convert any final results into the ..Seconds values I'm using but that's not how I implemented this.
If you'd accept the PR as is I'll make an issue to look to remove the use of this extra package if that can be done.
There was a problem hiding this comment.
This has been running on my systems since April so it would be good to get these extra metrics into orchestrator.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I forgot to expose the api calls in a previous PR. This fixes this.
Add the following api calls
gofmt(please avoidgoimports)./build.shgo test ./go/...