ipq-wifi/ath10k: fix 5GHz radio detection in Xiaomi AIoT AC2350 #19707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can squash the second and third commits, no need to split those as just adding calibration variant without the ipq-wifi package is NOP |
cf0db1a to
f316b88
Compare
|
Please rebase, and squash the first and third commit |
94fd995 to
7ab99f5
Compare
robimarko
reviewed
Aug 26, 2025
target/linux/ath79/image/generic.mk
Outdated
| @@ -3326,7 +3326,7 @@ define Device/xiaomi_aiot-ac2350 | |||
| SOC := qca9563 | |||
| DEVICE_VENDOR := Xiaomi | |||
| DEVICE_MODEL := AIoT AC2350 | |||
| DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9984-ct | |||
| DEVICE_PACKAGES := kmod-ath10k-ct ath10k-firmware-qca9984-ct -ath10k-board-qca9984 ipq-wifi-xiaomi_aiot-ac2350 | |||
There was a problem hiding this comment.
No need to drop ath10k-board-qca9984 as ipq-wifi will overwrite it anyway.
There was a problem hiding this comment.
Removed, I was following the reference: 427c4aa
|
Can you please rework your commit titles and messages into 75 characters per line max instead of just a single line? |
7ab99f5 to
b80674d
Compare
|
@robimarko Should I shorten the description as much as possible or just split it into multiple lines? |
|
Just split into multiple lines |
b80674d to
66033cc
Compare
Add IPQ WiFi support for Xiaomi AIoT AC2350 Add board file suffixes .QCA9988/.qca9988. These suffixes are mapped to QCA9984/hw1.0 path Reference: https://openwrt.org/toh/xiaomi/aiot_router_ac2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com>
Add calibration variant and ipq-wifi package for Xiaomi AIoT AC2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com>
66033cc to
664424a
Compare
|
Thanks! Rebased on top of main and merged! |
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Aug 29, 2025
Add IPQ WiFi support for Xiaomi AIoT AC2350 Add board file suffixes .QCA9988/.qca9988. These suffixes are mapped to QCA9984/hw1.0 path Reference: https://openwrt.org/toh/xiaomi/aiot_router_ac2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Aug 29, 2025
Add calibration variant and ipq-wifi package for Xiaomi AIoT AC2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com>
igor-dyatlov
added a commit
to igor-dyatlov/openwrt
that referenced
this pull request
Aug 29, 2025
Add IPQ WiFi support for Xiaomi AIoT AC2350 Add board file suffixes .QCA9988/.qca9988. These suffixes are mapped to QCA9984/hw1.0 path Reference: https://openwrt.org/toh/xiaomi/aiot_router_ac2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit c42f05b)
igor-dyatlov
added a commit
to igor-dyatlov/openwrt
that referenced
this pull request
Aug 29, 2025
Add calibration variant and ipq-wifi package for Xiaomi AIoT AC2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit 664424a)
hauke
pushed a commit
to igor-dyatlov/openwrt
that referenced
this pull request
Aug 31, 2025
Add IPQ WiFi support for Xiaomi AIoT AC2350 Add board file suffixes .QCA9988/.qca9988. These suffixes are mapped to QCA9984/hw1.0 path Reference: https://openwrt.org/toh/xiaomi/aiot_router_ac2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit c42f05b) Link: openwrt#19902 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
hauke
pushed a commit
to igor-dyatlov/openwrt
that referenced
this pull request
Aug 31, 2025
Add calibration variant and ipq-wifi package for Xiaomi AIoT AC2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit 664424a) Link: openwrt#19902 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Lienol
pushed a commit
to Lienol/openwrt
that referenced
this pull request
Sep 7, 2025
Add IPQ WiFi support for Xiaomi AIoT AC2350 Add board file suffixes .QCA9988/.qca9988. These suffixes are mapped to QCA9984/hw1.0 path Reference: https://openwrt.org/toh/xiaomi/aiot_router_ac2350 Signed-off-by: Igor Dyatlov <dyatlov.igor@gmail.com> Link: openwrt/openwrt#19707 Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the release of 24.10 on Xiaomi AIoT AC2350 5GHz WiFi stopped working.
I already added BDF but without an option, it didn't work. (tested on snapshot)
BoardNames[0]: 'bus=pci,bmi-chip-id=0,bmi-board-id=16'andBoardNames[0]: 'bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=xiaomi_aiot-ac2350'Related: openwrt/firmware_qca-wireless#83
What do you think?
Issues: #17582 #18496