Skip to content

Conversation

hongbo-wei
Copy link
Contributor

@hongbo-wei hongbo-wei commented Apr 5, 2024

This pull request adds support for the TensorFlow "MatrixInverse" operation to OpenVINO's TensorFlow Frontend (TF FE). It implements a new loader function translate_matrix_inverse_op that translates the TensorFlow operation into the equivalent OpenVINO Inverse operation (from opset-14) for both real-valued and complex-valued inputs.

Addresses issue: #22957

@hongbo-wei hongbo-wei requested a review from a team as a code owner April 5, 2024 01:26
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Apr 5, 2024
Copy link
Member

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update other files and add test.
See other PRs as examples: #23418

hongbo-wei and others added 3 commits April 5, 2024 13:51
Copy link
Contributor Author

@hongbo-wei hongbo-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkazants Code updated accordingly, please review and guide me, thank you! : )

Copy link
Member

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translator gets better. Now please register this translator in op_table etc. See other PRs.
Also test is needed:)

@rkazants
Copy link
Member

build_jenkins

@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants added this to the 2024.2 milestone Apr 13, 2024
@rkazants rkazants added the ExternalPR External contributor label Apr 13, 2024
@rkazants rkazants self-assigned this Apr 13, 2024
@rkazants
Copy link
Member

rkazants commented Apr 13, 2024

Looks that we have an issue with MatrixInverse for adjoint=True in our opset. I will figure out this with a team internally.
For now I propose to support adjoint=False case and merge it.

@rkazants
Copy link
Member

build_jenkins

@hongbo-wei
Copy link
Contributor Author

Looks that we have an issue with MatrixInverse for adjoint=True in our opset. I will figure out this with a team internally. For now I propose to support adjoint=False case and merge it.

Thank you, Roman! I'm so so so happy that I'm going to have my first real GitHub contribution to be merged. All the best for OpenVINO and Intel. 😃

@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants enabled auto-merge April 13, 2024 14:14
@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants added this pull request to the merge queue Apr 13, 2024
Merged via the queue into openvinotoolkit:master with commit 0287267 Apr 13, 2024
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
…kit#23881)

This pull request adds support for the TensorFlow "**MatrixInverse**"
operation to OpenVINO's TensorFlow Frontend (TF FE). It implements a new
loader function translate_matrix_inverse_op that translates the
TensorFlow operation into the equivalent OpenVINO Inverse operation
(from opset-14) for both real-valued and complex-valued inputs.

Addresses issue:
#[22957](openvinotoolkit#22957)

Hi Roman @rkazants, could you please review my work, thank you!

---------

Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support MatrixInverse operation for TensorFlow
2 participants