Add support for go module when running generate command
#578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fix This changes how `generate` command looks for import path. Now it will try to find `go.mod` file and determine import path from there first, and will fallback to old way otherwise. [Fixes onsi#524]
|
@onsi Who would be best to review this? This is a pain point now that modules are GA |
|
Hi @kvptkr @leninhasda. The implementation here looks good and has worked for me when I have tried it out. The thing that this PR is missing is some tests, which could live here: https://github.com/onsi/ginkgo/blob/master/integration/subcommand_test.go#L16 |
|
@leninhasda, thank you for this contribution. It's a valuable improvement. I have added a test for it in commit 8892a1d as this will hopefully reduce the chance of this being accidentally broken in the future. If you can see any potential improvement to the testing, then please feel free to submit another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for go module when running
generatecommandTypo fix
This changes how
generatecommand looks for import path. Now it willtry to find
go.modfile and determine import path from there first,and will fallback to old way otherwise.
Ref:
Two functions I used are from original go source code:
[Fixes #524]