-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix shape
data propagation function to handle missing optional parameters
#5219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shape
data propagation function to handle missing optional parameters
#5219
Conversation
…ters Signed-off-by: BowenBao <bowbao@microsoft.com>
Signed-off-by: BowenBao <bowbao@microsoft.com>
Thanks for the fix. I don't think it has to do with optional parameter (because Shape doesn't have an optional parameter). But this problem can show up in other cases (eg., erroneous model, etc.). The model-checker will catch cases where we have a call to Shape without a parameter, but if we try running shape-inference before running the checker (as you mentioned elsewhere), this could be a problem. It could happen in other places too, because this style of code has been used quite a bit. |
As I discuss elsewhere, this could be a cascading problem arising out of the fact that attribute-parameters with default-values are not yet handled by checker/inference. |
Thanks @gramalingam for analysis! Indeed there is another root problem to be fixed. I'm going to try track in the example model where it first happened. Will update on the original issue. |
This change helps me process the short-example you had ("maf_gpt2_tiny.onnx"). May be you can try it on the bigger example. (I am sure there will be other places where change is required to handle attributes-with-default-values.) |
This comment was marked as duplicate.
This comment was marked as duplicate.
…meters (onnx#5219) Signed-off-by: BowenBao <bowbao@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Yu Cong <congyc@amazon.com>
…meters (onnx#5219) Signed-off-by: BowenBao <bowbao@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
…meters (onnx#5219) Signed-off-by: BowenBao <bowbao@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
…meters (onnx#5219) Signed-off-by: BowenBao <bowbao@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Fixes #5212