This repository was archived by the owner on Apr 1, 2020. It is now read-only.
Bugfix/fix tabs focus state border regression #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2558 +/- ##
==========================================
+ Coverage 44.93% 44.94% +0.01%
==========================================
Files 352 352
Lines 14336 14336
Branches 1863 1863
==========================================
+ Hits 6442 6444 +2
+ Misses 7669 7667 -2
Partials 225 225
Continue to review full report at Codecov.
|
CrossR
approved these changes
Sep 9, 2018
|
Thanks for reviewing 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CrossR seems there was one small-ish regression with the tabs the border top of the inactive tabs is supposed to be transparent so there isnt a resizing flicker this PR fixes it and adds some test cases for the functionality.
I'll avoid using cherry pick commits from #1915 in the future, since it was a WIP and its hard to know what bits were converted or how, makes it hard for me to find the regressions, but think this was it for that branch will create one from scratch for the menu components and later the other bits